Timeline for Deserialize with LINQ query code in PageModel or PageView
Current License: CC BY-SA 4.0
25 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 23, 2019 at 7:26 | vote | accept | Asons | ||
| Aug 23, 2019 at 7:25 | comment | added | t3chb0t | You posted it in the right place. Yes, CR reviews can be about anything. You're saying you are interested primarily in reviews about the logic and yet you remove crucial parts of it. Software Engineering will send you back to us when you show them the code. If you really want only logic reviews then make sure you describe it clearly. Code is rarely necessary for it. They accept also pseudocode, we don't. | |
| Aug 23, 2019 at 7:18 | comment | added | Asons | @t3chb0t -- Well, the but I already do this were about a very minor thing in my case, a null check, which has nothing to do with what I actually asked. I assume you review all the code, not the logic of it, which I asked for. Maybe I should have posted at Software Engineering instead...? | |
| Aug 23, 2019 at 7:11 | comment | added | t3chb0t | Nope, I mean that the posted code should be complete. Not your entire application but a method... a class, a (partial)view etc. Otherwise this is the result... you get a review and you replay but I already do this... it simply backfires and isn't helpful to anyone, especially to you. | |
| Aug 23, 2019 at 7:06 | comment | added | Asons | @t3chb0t -- Are you saying that I should have posted 1200 lines of code + all the linked/used utility library methods, and then ask about 20 lines of them (the one I posted), which is the main logic of my question? | |
| Aug 23, 2019 at 6:59 | comment | added | t3chb0t | When you do this, then I'll vote to close your qustion for posting hyphotetical code as this is off-topic on Code Review. I'll also delete my answer. Let's preted this has never happened ;-P and next time, please just copy/paste all of your code without changing it. | |
| Aug 23, 2019 at 6:59 | comment | added | Mast♦ | This is not a forum where you should keep the most updated version in your question. Please see what you may and may not do after receiving answers. | |
| Aug 23, 2019 at 6:52 | comment | added | t3chb0t | I had to rollback your last edit as it is not allowed to modify the code after reviews have been posted. It could (and in this case it did) invalidate them. | |
| Aug 23, 2019 at 6:51 | history | rollback | t3chb0t |
Rollback to Revision 12
|
|
| Aug 23, 2019 at 6:50 | history | edited | Asons | CC BY-SA 4.0 |
added 362 characters in body
|
| Aug 22, 2019 at 18:47 | history | edited | t3chb0t | CC BY-SA 4.0 |
edited title and tags
|
| Aug 22, 2019 at 18:43 | answer | added | t3chb0t | timeline score: 2 | |
| Aug 13, 2019 at 14:23 | history | edited | Asons | CC BY-SA 4.0 |
deleted 147 characters in body
|
| Aug 13, 2019 at 12:47 | history | edited | Asons |
edited tags
|
|
| Aug 13, 2019 at 12:09 | history | edited | Asons | CC BY-SA 4.0 |
deleted 248 characters in body
|
| Aug 13, 2019 at 11:56 | history | edited | Asons | CC BY-SA 4.0 |
deleted 38 characters in body
|
| Aug 13, 2019 at 11:46 | history | edited | Asons | CC BY-SA 4.0 |
deleted 38 characters in body
|
| Aug 13, 2019 at 11:24 | history | edited | Asons | CC BY-SA 4.0 |
added 174 characters in body
|
| Aug 13, 2019 at 10:55 | review | Close votes | |||
| Aug 13, 2019 at 12:00 | |||||
| Aug 13, 2019 at 10:49 | history | edited | Asons | CC BY-SA 4.0 |
edited title
|
| Aug 13, 2019 at 10:35 | history | edited | t3chb0t |
edited tags
|
|
| Aug 13, 2019 at 10:34 | history | edited | Asons | CC BY-SA 4.0 |
added 20 characters in body
|
| Aug 13, 2019 at 10:22 | history | edited | Asons | CC BY-SA 4.0 |
added 91 characters in body
|
| Aug 13, 2019 at 10:15 | review | First posts | |||
| Aug 13, 2019 at 12:09 | |||||
| Aug 13, 2019 at 10:13 | history | asked | Asons | CC BY-SA 4.0 |