Skip to main content
5 events
when toggle format what by license comment
Jun 20, 2019 at 0:30 comment added Edward Since you asked, context that would help people review the code would include: brief descriptions of the four public members of the main class -- is there sequencing required? What are the parameters supposed to do? Just a sample stub showing the sequence of calls and the expected result would be useful.
Jun 19, 2019 at 22:00 comment added Edward You're right -- I had mixed old and new content. Fixed now (and updated the review to match). I'll look at this more later and add to the review if I can.
Jun 19, 2019 at 21:59 history edited Edward CC BY-SA 4.0
reduced review to new code only
Jun 19, 2019 at 21:46 comment added Arsenal long long was probably supported as an extension of the IAR compiler long (no pun intended) before C++11, wasn't actually aware that that is a new feature. You are mixing up the source file before the changes with the header file after the changes, that's why your compiler doesn't like it. What kind of context would improve the question to make it easier to review? I find it very hard to cut out enough context without making the whole thing explode. Maybe the heart of my question is better asked somewhere else...
Jun 19, 2019 at 21:23 history answered Edward CC BY-SA 4.0