Timeline for SHA256 implemented in Rust
Current License: CC BY-SA 4.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 12, 2020 at 12:16 | comment | added | Maarten Bodewes | The above code looks good from a design perspective IMHO. I'm a bit wondering why you decided to mix main and part of the function though. I'd first test against test vectors, then optimize (unroll loop, inline functions) and finally clean up. If you use vars from the standard or from another implementation, then please provide a reference to that standard in the code (visiting unanswered crypto questions). | |
| Jul 9, 2019 at 18:00 | history | tweeted | twitter.com/StackCodeReview/status/1148653184140943360 | ||
| Jun 7, 2019 at 17:56 | comment | added | JayDepp |
Also note that returning the array [Wrapping<u32>; 64] requires copying 4*64 = 256 bytes if not optimized away. You may prefer taking a &mut [Wrapping<u32>; 64] argument if the function is in a hot loop or otherwise determined to be taking a lot of time.
|
|
| Jun 7, 2019 at 17:45 | comment | added | JayDepp |
Check out -C target-cpu=native. Also, assuming your benchmark includes I/O, note that stdout is line buffered and must be locked on every call to print. See this helpful article.
|
|
| S Jun 7, 2019 at 5:21 | history | suggested | dfhwze |
added tags for lookup
|
|
| Jun 7, 2019 at 5:20 | review | Suggested edits | |||
| S Jun 7, 2019 at 5:21 | |||||
| Jun 7, 2019 at 5:16 | history | asked | user668074 | CC BY-SA 4.0 |