Skip to main content
added 147 characters in body
Source Link
chux
  • 33.6k
  • 2
  • 38
  • 92

Initial position

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....

Backwards?

play_recording() looks like tail = tail->prev; is playing back in reverse order.   I'd expect re-play to start at the beginning and play use tail = tail->prev;>next does not well imply a queue.

Need to see add_function().

Initial position

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....

Backwards?

play_recording() looks like tail = tail->prev; is playing back in reverse order.  tail = tail->prev; does not well imply a queue.

Need to see add_function().

Initial position

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....

Backwards?

play_recording() looks like tail = tail->prev; is playing back in reverse order. I'd expect re-play to start at the beginning and play use ->next.

Need to see add_function().

added 147 characters in body
Source Link
chux
  • 33.6k
  • 2
  • 38
  • 92

Initial position

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....

Backwards?

play_recording() looks like tail = tail->prev; is playing back in reverse order. tail = tail->prev; does not well imply a queue.

Need to see add_function().

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....

Initial position

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....

Backwards?

play_recording() looks like tail = tail->prev; is playing back in reverse order. tail = tail->prev; does not well imply a queue.

Need to see add_function().

Source Link
chux
  • 33.6k
  • 2
  • 38
  • 92

add_cursor() only adds the cursor's position to the function's queue if there is a change.

Depending on needs, I'd expect the initial mouse position to be added too and not assume it is {0,0}. Presently, the true initial mouse position is never saved.

Suggest:

POINT cursor_buff[2] = { get_cursor(), { 0,0}};
add_function(head, tail, _GETCURSOR, cursor_buff[0].x, cursor_buff[0].y);

while(key_buff[1] != KEY_W) {
  ....