Timeline for Extracting the parent, leaf, and extension from a valid path
Current License: CC BY-SA 4.0
19 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 7, 2019 at 22:30 | comment | added | user200189 |
@KonradRudolph - Were do you see that invalid syntax in _parse_extension? My code runs, I tested it before I posted it on CR.
|
|
| May 7, 2019 at 15:41 | vote | accept | CommunityBot | ||
| May 7, 2019 at 11:37 | comment | added | Peilonrayz♦ | Let us continue this discussion in chat. | |
| May 7, 2019 at 11:30 | comment | added | Peilonrayz♦ | @KonradRudolph Wow, I've asked for the same thing consistently, and you're unable to explain yourself. So you tell me to have some sleep? Wat. If you really feel my answer doesn't follow the rules of Code Review.SE then you can post a question on our Meta | |
| May 7, 2019 at 11:28 | comment | added | Konrad Rudolph | I suggest giving it a night’s sleep and then reading your answer, the comments and the meta discussion again. | |
| May 7, 2019 at 11:18 | comment | added | Peilonrayz♦ | @KonradRudolph I have read it again. What "review" aspect is it missing? And again, why have you linked me that meta? | |
| May 7, 2019 at 11:15 | comment | added | Konrad Rudolph | Because it supports my initial comment that your answer, while valuable, lacks the “review” aspect that’s expected. I suggest you actually read the linked meta discussion. | |
| May 7, 2019 at 11:13 | comment | added | Peilonrayz♦ | @KonradRudolph Why are you referring me to that meta? | |
| May 7, 2019 at 11:13 | comment | added | Konrad Rudolph | “specific” as in specific to the code posted, rather than general for any code solving the same issue. This is by the way all very well established on this website, see codereview.meta.stackexchange.com/a/8410/308 | |
| May 7, 2019 at 11:05 | comment | added | Peilonrayz♦ | @KonradRudolph I don't know what your definition of 'feedback' is. However this answer provides specific feedback to the code in the question. The note is specific to this question and the code I've provided also is specific to this question. I also wouldn't be able to provide this feedback, verbatim, to another question, as it's specific to this question. | |
| May 7, 2019 at 10:58 | comment | added | Konrad Rudolph |
I have to admit that I’m a bit puzzled as to where the issue is. A review gives specific feedback about the code under discussion. Your answer doesn’t do this at all. Instead, it suggests an alternative. This is of course entirely valid, but it’s not a review, and it’s not feedback. Examples of specific feedback for OP’s code would be: “Well done on using type hints for the method arguments; don’t forget to also annotate return types”, or “your method names are too verbose”; or “ _parse_extension contains invalid syntax”.
|
|
| May 7, 2019 at 10:24 | comment | added | Peilonrayz♦ |
Clearly we have a difference of opinion of what "no feedback" is. I've clearly shown how the OP's parse_file_path can be simplified. Since it seems you're unable to explain your POV, and for some unknown reason limit your explanations to ambiguous statements such as "this isn't a code review", then I cannot help you. Please post an answer which fills in the aspects you find lacking in mine.
|
|
| May 7, 2019 at 10:11 | comment | added | Konrad Rudolph | Well it’s not a code review. As in, you provide no feedback for OP’s code. | |
| May 6, 2019 at 22:26 | comment | added | Peilonrayz♦ | @KonradRudolph What do you feel is lacking in my answer? I may be able to provide it if I know what 'it' is. | |
| May 6, 2019 at 22:25 | comment | added | Konrad Rudolph | So far so good for a better alternative. But it's not much of a code review. And OP could definitely benefit from a code review. | |
| May 6, 2019 at 22:06 | history | edited | Peilonrayz♦ | CC BY-SA 4.0 |
Fix a misspelling. Thank you @Graipher
|
| May 6, 2019 at 18:13 | history | edited | Peilonrayz♦ | CC BY-SA 4.0 |
Add os.path
|
| May 6, 2019 at 18:03 | history | edited | Peilonrayz♦ | CC BY-SA 4.0 |
added 5 characters in body
|
| May 6, 2019 at 17:58 | history | answered | Peilonrayz♦ | CC BY-SA 4.0 |