Timeline for New to TDD, am I doing everything right? How could I improve?
Current License: CC BY-SA 3.0
17 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Feb 11, 2013 at 8:56 | comment | added | Jocke | I would recommend using code.google.com/p/moq for easy creating moq objects | |
Feb 5, 2013 at 9:36 | vote | accept | Adam K Dean | ||
Feb 5, 2013 at 0:34 | answer | added | Mr.Mindor | timeline score: 1 | |
Feb 4, 2013 at 19:48 | history | tweeted | twitter.com/#!/StackCodeReview/status/298518321073111041 | ||
Feb 4, 2013 at 16:29 | answer | added | Songo | timeline score: 3 | |
Feb 4, 2013 at 16:13 | comment | added | Winston Ewert | @AdamKDean, don't count return values that simply indicate success towards that one assert. There is a good chance they should be exceptions anyways. | |
Feb 4, 2013 at 16:11 | answer | added | Winston Ewert | timeline score: 5 | |
Feb 4, 2013 at 15:53 | comment | added | Adam K Dean | I initially had it like that, Ginosaji, but then I read one-test-one-assert and thought I had too much going on. I was calling GetUserByName to test AddUser and thought - am I doing this wrong by testing both GetUserByName and AddUser? Should I make the underlying UserData list publicly readable and check that? | |
Feb 4, 2013 at 15:46 | comment | added | JosephHirn |
Your test cases could be a little more robust. For example, instead of only testing that AddUser returns true, you should ensure that it actually added the user. Other than that, it sounds like you have the process down.
|
|
Feb 4, 2013 at 15:46 | answer | added | Dan | timeline score: 2 | |
Feb 4, 2013 at 15:44 | comment | added | CodesInChaos | Personally I'd use a single fields for password hash+salt. Then splitting, combining and generating them is an implementation details of your password hashing class. | |
Feb 4, 2013 at 15:44 | answer | added | jgauffin | timeline score: 3 | |
Feb 4, 2013 at 15:43 | comment | added | Adam K Dean | Thanks, that's exactly the kind of feedback I am looking for! :) | |
Feb 4, 2013 at 15:39 | comment | added | hometoast | One thing I notice off hand is you might find it easier to use the ExpectedExceptionAttribute | |
Feb 4, 2013 at 15:35 | history | edited | svick | CC BY-SA 3.0 |
rm tag from title
|
Feb 4, 2013 at 15:34 | history | migrated | from stackoverflow.com (revisions) | ||
Feb 4, 2013 at 15:32 | history | asked | Adam K Dean | CC BY-SA 3.0 |