Timeline for Date input wrapper for TextBox
Current License: CC BY-SA 4.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 22, 2018 at 10:44 | comment | added | TinMan | I realized after I shut my computer down that the placeholder should be its own class/ | |
| Oct 22, 2018 at 10:43 | comment | added | TinMan |
The logic for your isLeapYear() function is backwards. Compare it this answer to How do you find Leapyear in VBA?. Notice that all the conditions are that ? Mod ? = 0 where as your code is ? Mod ? > 0.
|
|
| Oct 22, 2018 at 10:38 | comment | added | TinMan |
@Comintern Aww...thanks for the correction on the Gregorian calendar. I had test my code against Teachers Page - Leap Year that goes back to 1908. But you are correct my code does not take in all scenarios. My isValidDate() replacement is still correct because I let the VBA handle the leap years.
|
|
| Oct 22, 2018 at 10:29 | history | edited | TinMan | CC BY-SA 4.0 |
added 284 characters in body
|
| Oct 22, 2018 at 5:18 | comment | added | Comintern | Re the UX, persistable input masks would be an easy change (or perhaps another configuration), but were not in the problem domain. Thanks for the review! | |
| Oct 22, 2018 at 5:17 | comment | added | Comintern |
The leap year calculation should be correct. Divisible by 4 was in the Julian calendar, but it was corrected in the Gregorian. Re the IsValidDate, :doh: I was victim of my own last minute refactor - those should have been comma delimited instead of 3 separate cases. Agreed that changes to the setup should trigger updates too (I realized that about an hour after I posted the code). You are absolutely correct about KeyCodeConstants - completely spaced that they were already defined.
|
|
| Oct 22, 2018 at 3:40 | history | answered | TinMan | CC BY-SA 4.0 |