Timeline for BattleShip Grid: Classes and Tests
Current License: CC BY-SA 4.0
13 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 22, 2018 at 5:35 | vote | accept | Mathieu Guindon | ||
| Aug 21, 2018 at 13:44 | comment | added | Mathieu Guindon |
@FreeMan that is indeed a bug indicating insufficient test coverage, and is answer-worthy! However do note that the (x,y) notation is, as mentioned, not user-facing - it's only used internally, when storing grid coordinates as, say, dictionary keys, in a way that can easily be converted back into a GridCoord instance. Also.... "A1" stands for coordinate (1,1) in a game grid, not on a worksheet - while there is a "worksheet UI", the entire game logic is blissfully unaware of what the UI consists of; it's not implemented yet, but there will also be a "UserForm UI" to play with.
|
|
| Aug 21, 2018 at 13:01 | comment | added | FreeMan |
Public Function FromString(ByVal coord As String) As GridCoord will accept (1,2,3) and return 1 & 3 without complaint. It won't like it very much if you feed it ("x","y","z"), or even an expected ("x","y"). Of course, you should expect numeric grid coordinates. Or should you... You are playing in Excel where most people will refer to cell "A1", and the official Battleship game is laid out with letters for the X-coordinate...
|
|
| Aug 21, 2018 at 8:50 | answer | added | M.Doerner | timeline score: 4 | |
| Aug 21, 2018 at 6:01 | history | tweeted | twitter.com/StackCodeReview/status/1031783445985419265 | ||
| Aug 21, 2018 at 5:59 | history | edited | Mathieu Guindon | CC BY-SA 4.0 |
edited body
|
| Aug 21, 2018 at 5:53 | history | edited | Mathieu Guindon | CC BY-SA 4.0 |
fixed buggy PlayerGrid.GetHitArea method
|
| Aug 21, 2018 at 5:32 | comment | added | Mast♦ | Holy carp, that's neat. | |
| Aug 21, 2018 at 4:47 | comment | added | Raystafarian |
PlayerGrid also refers to the IShip interface
|
|
| Aug 21, 2018 at 4:31 | history | edited | Mathieu Guindon | CC BY-SA 4.0 |
added 1884 characters in body
|
| Aug 21, 2018 at 4:23 | history | edited | Mathieu Guindon | CC BY-SA 4.0 |
added 70 characters in body
|
| Aug 21, 2018 at 4:13 | history | edited | Mathieu Guindon | CC BY-SA 4.0 |
added 486 characters in body
|
| Aug 21, 2018 at 3:57 | history | asked | Mathieu Guindon | CC BY-SA 4.0 |