Timeline for Looping JSON in WebAPI Controller and Add new Property
Current License: CC BY-SA 4.0
27 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 25, 2018 at 22:23 | vote | accept | VinnyGuitara | ||
| Jul 25, 2018 at 17:17 | answer | added | Matt Cole | timeline score: 2 | |
| S Jul 25, 2018 at 13:01 | history | bounty ended | CommunityBot | ||
| S Jul 25, 2018 at 13:01 | history | notice removed | CommunityBot | ||
| Jul 24, 2018 at 21:46 | comment | added | Matt Cole | So if your 1000 items each have on average 3 tokenized fields that is 1000*3*1.5 = 4500ms for your intermediate call? Seems it would be the bottleneck if this is accurate. | |
| Jul 24, 2018 at 13:15 | comment | added | VinnyGuitara | @MattCole - MakeRequest takes about 1.5 millisecond per record to return which is right on target. Seems the initial loop through the json to build the payload FOR MakeRequest is taking some time as well as after MakeRequest returns and we loop it's payload and merge it with the initial JSON that is taking some time. Seems the bottle neck is in the code I've posted. | |
| Jul 23, 2018 at 17:56 | comment | added | Matt Cole |
Have you identified what is slow? How long does it take MakeRequest() to return?
|
|
| Jul 19, 2018 at 21:09 | comment | added | VinnyGuitara | I've fully updated the functions/payloads - hopefully that helps. | |
| S Jul 17, 2018 at 11:33 | history | bounty started | VinnyGuitara | ||
| S Jul 17, 2018 at 11:33 | history | notice added | VinnyGuitara | Draw attention | |
| Jul 16, 2018 at 14:51 | comment | added | VinnyGuitara | I had to make sure it was sanitized and ok to do so :). I was unable to post the intermediate service (the optimized one) that returns the values to my function. Thanks for taking the time to look. | |
| Jul 16, 2018 at 14:18 | comment | added | t3chb0t | I'm not happy about you not posting the entire code the first time but I'm glad you've decided to do it after all ;-) | |
| Jul 16, 2018 at 14:07 | history | edited | VinnyGuitara | CC BY-SA 4.0 |
Updated with entire function.
|
| Jul 16, 2018 at 14:00 | comment | added | VinnyGuitara | @t3chb0t - I was able to add the payload/response example JSON... Hopefully that helps. | |
| Jul 16, 2018 at 14:00 | comment | added | VinnyGuitara | @FurkanKambay - I was able to change those lines and for readability they should stay like that but it didn't decrease the latency between the call and response. | |
| Jul 16, 2018 at 13:53 | history | edited | VinnyGuitara | CC BY-SA 4.0 |
Updated with sample json payloads. Tried to edit them my best for readability.
|
| Jul 16, 2018 at 13:42 | comment | added | VinnyGuitara | This function is an azure function... this was the template they start you off with. I sure can try that. Let me also upload some sample json. Working on that now, just have to sanitize it. | |
| Jul 16, 2018 at 3:47 | comment | added | Furkan Kambay |
In the first line of the method, why read as dynamic when you are casting it to JObject in the next line? Can you replace those 2 lines with JObject.Parse(await req.Content.ReadAsStringAsync())?
|
|
| Jul 15, 2018 at 3:49 | comment | added | VinnyGuitara | I just saw this. I will post some sample json and result tomorrow morning. Thanks. | |
| Jul 13, 2018 at 18:17 | comment | added | t3chb0t | Could you also add a sample of the json you are transforming to have something to play with? A sample result would be also very helpful :-] | |
| Jul 13, 2018 at 18:05 | history | edited | t3chb0t | CC BY-SA 4.0 |
fixed copy/paste indentation
|
| Jul 13, 2018 at 18:04 | comment | added | t3chb0t | This looks much better now ;-) I think the whole class isn't necessary here. The method provides enough context. | |
| Jul 13, 2018 at 18:02 | comment | added | VinnyGuitara | Was only able to put the function in not the whole class. The only other method in the class is the call to the remote service. | |
| Jul 13, 2018 at 18:01 | history | edited | VinnyGuitara | CC BY-SA 4.0 |
added 706 characters in body
|
| Jul 13, 2018 at 17:56 | comment | added | VinnyGuitara | sure give me a moment and I will do that.... just FYI the bottleneck is in the first function the remote service called cannot be modified and is already optimized. Let me upload the entire class. | |
| Jul 13, 2018 at 17:55 | comment | added | t3chb0t | Please post the complete method, not a random snippet. If possible the class. | |
| Jul 13, 2018 at 17:54 | history | asked | VinnyGuitara | CC BY-SA 4.0 |