Given an array of integers, replace every element with the next
greatest element (greatest element on the right side) in the array.
Since there is no element next to the last element, replace it with
-1.
Input:
The first line of input contains an integer T denoting the number of
test cases. The first line of each test case is N,N is the size of
array. The second line of each test case contains N input A[i].
Output:
Print the modified array.
Constraints:
1 ≤ T ≤ 50 1 ≤ N ≤ 100 1 ≤ A[i] ≤ 1000
Example:
Input: 2 6 16 17 4 3 5 2 4 2 3 1 9
Output: 17 5 5 5 2 -1 9 9 9 -1
My approach:
/*package whatever //do not write package name here */
import java.io.InputStreamReader;
import java.io.BufferedReader;
import java.io.IOException;
import java.util.Collections;
class GFG {
private static int [] calcNewArr(int [] arr)
{
int [] ans = new int[arr.length];
ans[0] = getNextBiggest(arr,1);
for (int i = 1; i < arr.length - 1; i++)
{
ans[i] = getNextBiggest(arr,i+1);
}
ans[ans.length - 1] = -1;
return ans;
}
private static int getNextBiggest (int [] arr, int start)
{
int max = Integer.MIN_VALUE;
for (int i = start; i < arr.length; i++ )
{
if ( max < arr[i])
{
max = arr[i];
}
}
return max;
}
public static void main (String[] args) throws IOException {
BufferedReader br = new BufferedReader (new InputStreamReader(System.in));
String line = br.readLine();
int numTests = Integer.parseInt(line);
String line2;
String line3;
int size;
int [] arr;
int [] result;
for (int i = 0; i < numTests; i++)
{
line2 = br.readLine();
size = Integer.parseInt(line2);
line3 = br.readLine();
String []inps = line3.split(" ");
arr = new int[size];
for (int j = 0; j < size; j++)
{
arr[j] = Integer.parseInt(inps[j]);
}
result = calcNewArr(arr);
for (int k = 0; k < size; k++)
{
System.out.print(result[k] + " ");
}
System.out.println();
}
}
}
I have the following questions with regards to the above code:
- How can I further improve my approach?
2.Is there a better way to solve this question?
Are there any grave code violations that I have committed?
Can space and time complexity be further improved?
Reference