Timeline for Get all combinations of selecting k elements from an n-sized array
Current License: CC BY-SA 4.0
4 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 24, 2018 at 13:42 | history | edited | Peter Taylor | CC BY-SA 4.0 |
added 719 characters in body
|
| May 24, 2018 at 13:35 | comment | added | Peter Taylor | "I did wrote that the values are unique and that order is irrelevant": in the question. I think that kind of constraint belongs in method-level documentation. "your comments doesn't really explain it either" is fair. I'll edit to improve that. | |
| May 24, 2018 at 12:45 | comment | added | Maverick Meerkat | I liked your method - it is cleaner and a bit more simple. And I understand your static vs. ctor comment (personally I would go with static). I did wrote that the values are unique and that order is irrelevant; Also, your logic is maybe a bit simpler, but not easier to understand without actually following it (i.e. your comments doesn't really explain it either). The rest (throw vs. return null, etc.) is a matter of taste. | |
| May 24, 2018 at 10:42 | history | answered | Peter Taylor | CC BY-SA 4.0 |