Skip to main content
Code Review

Return to Question

added 615 characters in body; edited title
Source Link
200_success
200_success
  • 144.2k
  • 22
  • 188
  • 473

This code is to very simple iOS app that signs people up for a street-ball league in theretheir neighborhood.

class WelcomeVC: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
        
        
    }

    @IBAction func unWindFromSkillVC(unwindSegue: UIStoryboardSegue) {
        
    }
   
}

import UIKit

class LeagueVC: UIViewController {

    
    var player: Player!
   
    override func viewDidLoad() {
        super.viewDidLoad()

        player = Player()
    }
    
    
    @IBAction func onMensTapped(_ sender: Any) {
        selectLeague(leagueType: "mens")
        performSegue(withIdentifier: "mensVCSegue", sender: self)
        
    }
    
    @IBAction func onWomensTapped(_ sender: Any) {
        selectLeague(leagueType: "womens")
        performSegue(withIdentifier: "womensVCSegue", sender: self)
    }
    
    @IBAction func onCoedTapped(_ sender: Any) {
        selectLeague(leagueType: "coed")
        performSegue(withIdentifier: "coedVCSegue", sender: self)
    }
    
    
    func selectLeague(leagueType: String) {
        player.desiredLeague = leagueType
      
    }
    
    override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
        if let mensVC = segue.destination as? MensVC {
            mensVC.player = player
        } else if let womensVC = segue.destination as? WomensVC {
            womensVC.player = player
        } else if let coedVC = segue.destination as? CoedVC {
            coedVC.player = player
        }
    }
}

}

class CoedVC: UIViewController {

    var player: Player!
    
    
    override func viewDidLoad() {
        super.viewDidLoad()

        print(player.desiredLeague)
    }

    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }
    

    @IBAction func beginnerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "beginner")
    }
    
    @IBAction func ballerBtnPressed(_ sender: Any) {
       selectSkillLevel(skillLevel: "baller")
    }
    
    
    func selectSkillLevel(skillLevel: String) {
        player.selectedSkillLevel = skillLevel
        print(skillLevel)
    }
}

class WomensVC: UIViewController {

    var player: Player!
    
    override func viewDidLoad() {
        super.viewDidLoad()

        print(player.desiredLeague)
    }

    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }
    

    @IBAction func beginnerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "beginner")
    }
    
    @IBAction func ballerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "baller")
    }
    
    
    func selectSkillLevel(skillLevel: String) {
        player.selectedSkillLevel = skillLevel
        print(skillLevel)
    }
    
}

import UIKit

class MensVC: UIViewController {

    var player: Player!
    
    override func viewDidLoad() {
        super.viewDidLoad()
        
        print(player.desiredLeague)
    }
    
    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }

    
    @IBAction func beginnerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "beginner")
    }
    
    @IBAction func ballerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "baller")
    }
    
    func selectSkillLevel(skillLevel: String) {
        player.selectedSkillLevel = skillLevel
        print(skillLevel)
    }
    
}

Here is the GitHub link ->: https://github.com/andrewlundy/app-swooshhttps://github.com/andrewlundy/app-swoosh

This code is to very simple iOS app that signs people up for a street-ball league in there neighborhood.

class WelcomeVC: UIViewController {

 override func viewDidLoad() {
     super.viewDidLoad()
    
    
 }

 @IBAction func unWindFromSkillVC(unwindSegue: UIStoryboardSegue) {
    
 }

}

import UIKit

class LeagueVC: UIViewController {


var player: Player!

override func viewDidLoad() {
    super.viewDidLoad()

    player = Player()
}


@IBAction func onMensTapped(_ sender: Any) {
    selectLeague(leagueType: "mens")
    performSegue(withIdentifier: "mensVCSegue", sender: self)
    
}

@IBAction func onWomensTapped(_ sender: Any) {
    selectLeague(leagueType: "womens")
    performSegue(withIdentifier: "womensVCSegue", sender: self)
}

@IBAction func onCoedTapped(_ sender: Any) {
    selectLeague(leagueType: "coed")
    performSegue(withIdentifier: "coedVCSegue", sender: self)
}


func selectLeague(leagueType: String) {
    player.desiredLeague = leagueType
  
}

override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
    if let mensVC = segue.destination as? MensVC {
        mensVC.player = player
    } else if let womensVC = segue.destination as? WomensVC {
        womensVC.player = player
    } else if let coedVC = segue.destination as? CoedVC {
        coedVC.player = player
    }
}

}

class CoedVC: UIViewController {

var player: Player!


override func viewDidLoad() {
    super.viewDidLoad()

    print(player.desiredLeague)
}

override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
}


@IBAction func beginnerBtnPressed(_ sender: Any) {
    selectSkillLevel(skillLevel: "beginner")
}

@IBAction func ballerBtnPressed(_ sender: Any) {
   selectSkillLevel(skillLevel: "baller")
}


func selectSkillLevel(skillLevel: String) {
    player.selectedSkillLevel = skillLevel
    print(skillLevel)
}
}

class WomensVC: UIViewController {

 var player: Player!

 override func viewDidLoad() {
     super.viewDidLoad()

     print(player.desiredLeague)
 }

 override func didReceiveMemoryWarning() {
     super.didReceiveMemoryWarning()
     // Dispose of any resources that can be recreated.
 }


 @IBAction func beginnerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "beginner")
 }

 @IBAction func ballerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "baller")
 }


 func selectSkillLevel(skillLevel: String) {
     player.selectedSkillLevel = skillLevel
     print(skillLevel)
 }

}

import UIKit

class MensVC: UIViewController {

 var player: Player!

 override func viewDidLoad() {
     super.viewDidLoad()
    
     print(player.desiredLeague)
 }

 override func didReceiveMemoryWarning() {
     super.didReceiveMemoryWarning()
     // Dispose of any resources that can be recreated.
 }


 @IBAction func beginnerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "beginner")
 }

 @IBAction func ballerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "baller")
 }

 func selectSkillLevel(skillLevel: String) {
     player.selectedSkillLevel = skillLevel
     print(skillLevel)
 }
 
}

Here is the GitHub link -> https://github.com/andrewlundy/app-swoosh

iOS app that signs people up for a street-ball league in their neighborhood

class WelcomeVC: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
        
        
    }

    @IBAction func unWindFromSkillVC(unwindSegue: UIStoryboardSegue) {
        
    }
   
}

import UIKit

class LeagueVC: UIViewController {

    
    var player: Player!
   
    override func viewDidLoad() {
        super.viewDidLoad()

        player = Player()
    }
    
    
    @IBAction func onMensTapped(_ sender: Any) {
        selectLeague(leagueType: "mens")
        performSegue(withIdentifier: "mensVCSegue", sender: self)
        
    }
    
    @IBAction func onWomensTapped(_ sender: Any) {
        selectLeague(leagueType: "womens")
        performSegue(withIdentifier: "womensVCSegue", sender: self)
    }
    
    @IBAction func onCoedTapped(_ sender: Any) {
        selectLeague(leagueType: "coed")
        performSegue(withIdentifier: "coedVCSegue", sender: self)
    }
    
    
    func selectLeague(leagueType: String) {
        player.desiredLeague = leagueType
      
    }
    
    override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
        if let mensVC = segue.destination as? MensVC {
            mensVC.player = player
        } else if let womensVC = segue.destination as? WomensVC {
            womensVC.player = player
        } else if let coedVC = segue.destination as? CoedVC {
            coedVC.player = player
        }
    }
}

class CoedVC: UIViewController {

    var player: Player!
    
    
    override func viewDidLoad() {
        super.viewDidLoad()

        print(player.desiredLeague)
    }

    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }
    

    @IBAction func beginnerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "beginner")
    }
    
    @IBAction func ballerBtnPressed(_ sender: Any) {
       selectSkillLevel(skillLevel: "baller")
    }
    
    
    func selectSkillLevel(skillLevel: String) {
        player.selectedSkillLevel = skillLevel
        print(skillLevel)
    }
}

class WomensVC: UIViewController {

    var player: Player!
    
    override func viewDidLoad() {
        super.viewDidLoad()

        print(player.desiredLeague)
    }

    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }
    

    @IBAction func beginnerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "beginner")
    }
    
    @IBAction func ballerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "baller")
    }
    
    
    func selectSkillLevel(skillLevel: String) {
        player.selectedSkillLevel = skillLevel
        print(skillLevel)
    }
    
}

import UIKit

class MensVC: UIViewController {

    var player: Player!
    
    override func viewDidLoad() {
        super.viewDidLoad()
        
        print(player.desiredLeague)
    }
    
    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }

    
    @IBAction func beginnerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "beginner")
    }
    
    @IBAction func ballerBtnPressed(_ sender: Any) {
        selectSkillLevel(skillLevel: "baller")
    }
    
    func selectSkillLevel(skillLevel: String) {
        player.selectedSkillLevel = skillLevel
        print(skillLevel)
    }
    
}

Here is the GitHub link: https://github.com/andrewlundy/app-swoosh

Source Link
andrewlundy_
andrewlundy_
  • 143
  • 6

This code is to very simple iOS app that signs people up for a street-ball league in there neighborhood.

I know there is some repeated code in here, which is why I need a code review. The point of this app is simple, the user opens it, taps "begin", they select their league - men's, women's or co-ed, and then they select their skill level.

The main issue I see with this is the fact that the button functions in the league VCs are all the same. I tried adding it to the BorderedButton.swift file, but it required that I add the player variable - which I figured was redundant to the fact that it is already in each league view controller.

Main View Controller:

class WelcomeVC: UIViewController {

 override func viewDidLoad() {
     super.viewDidLoad()
    
    
 }

 @IBAction func unWindFromSkillVC(unwindSegue: UIStoryboardSegue) {
    
 }

}

User arrives here after they select "continue" on the welcome screen. They then select which league they want to join. This gets the segues ready for the next view controller as well
League View Controller:

import UIKit

class LeagueVC: UIViewController {


var player: Player!

override func viewDidLoad() {
    super.viewDidLoad()

    player = Player()
}


@IBAction func onMensTapped(_ sender: Any) {
    selectLeague(leagueType: "mens")
    performSegue(withIdentifier: "mensVCSegue", sender: self)
    
}

@IBAction func onWomensTapped(_ sender: Any) {
    selectLeague(leagueType: "womens")
    performSegue(withIdentifier: "womensVCSegue", sender: self)
}

@IBAction func onCoedTapped(_ sender: Any) {
    selectLeague(leagueType: "coed")
    performSegue(withIdentifier: "coedVCSegue", sender: self)
}


func selectLeague(leagueType: String) {
    player.desiredLeague = leagueType
  
}

override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
    if let mensVC = segue.destination as? MensVC {
        mensVC.player = player
    } else if let womensVC = segue.destination as? WomensVC {
        womensVC.player = player
    } else if let coedVC = segue.destination as? CoedVC {
        coedVC.player = player
    }
}

}

User arrives here after they select the "co-ed" league, then they select their skill level.
Co-ed View Controller (controls the co-ed view controller):

class CoedVC: UIViewController {

var player: Player!


override func viewDidLoad() {
    super.viewDidLoad()

    print(player.desiredLeague)
}

override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
}


@IBAction func beginnerBtnPressed(_ sender: Any) {
    selectSkillLevel(skillLevel: "beginner")
}

@IBAction func ballerBtnPressed(_ sender: Any) {
   selectSkillLevel(skillLevel: "baller")
}


func selectSkillLevel(skillLevel: String) {
    player.selectedSkillLevel = skillLevel
    print(skillLevel)
}
}

User arrives here after they select the "women's" league, then they select their skill level.
Women's View Controller:

class WomensVC: UIViewController {

 var player: Player!

 override func viewDidLoad() {
     super.viewDidLoad()

     print(player.desiredLeague)
 }

 override func didReceiveMemoryWarning() {
     super.didReceiveMemoryWarning()
     // Dispose of any resources that can be recreated.
 }


 @IBAction func beginnerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "beginner")
 }

 @IBAction func ballerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "baller")
 }


 func selectSkillLevel(skillLevel: String) {
     player.selectedSkillLevel = skillLevel
     print(skillLevel)
 }

}

User arrives here after they select the "men's" league, then they select their skill level.
Men's View Controller:

import UIKit

class MensVC: UIViewController {

 var player: Player!

 override func viewDidLoad() {
     super.viewDidLoad()
    
     print(player.desiredLeague)
 }

 override func didReceiveMemoryWarning() {
     super.didReceiveMemoryWarning()
     // Dispose of any resources that can be recreated.
 }


 @IBAction func beginnerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "beginner")
 }

 @IBAction func ballerBtnPressed(_ sender: Any) {
     selectSkillLevel(skillLevel: "baller")
 }

 func selectSkillLevel(skillLevel: String) {
     player.selectedSkillLevel = skillLevel
     print(skillLevel)
 }
 
}

Here is the GitHub link -> https://github.com/andrewlundy/app-swoosh