Timeline for Constructor-injecting a truckload of commands
Current License: CC BY-SA 3.0
15 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 5, 2017 at 9:43 | answer | added | Aram Kocharyan | timeline score: 1 | |
| Oct 2, 2017 at 20:11 | answer | added | JanDotNet | timeline score: 4 | |
| Oct 2, 2017 at 14:56 | answer | added | CharlesNRice | timeline score: 1 | |
| Oct 1, 2017 at 18:01 | answer | added | JanDotNet | timeline score: 3 | |
| Sep 30, 2017 at 14:50 | comment | added | Mathieu Guindon |
Pretty sure the setters need to be public, but that's not an issue. Ninject's property injection requires set-only properties (no getter), which would mean double the member count. I'm open to ideas for factoring/splitting the ViewModel (e.g. ContextMenuViewModel, but at the end of the day the XAML needs all these properties for the command bindings.
|
|
| Sep 30, 2017 at 14:46 | comment | added | Aram Kocharyan | @Mat'sMug I agree with you, as long as having large amount (for example 30-40) of properties in ViewModel is acceptable. I was thinking about property injection (before choosing service locator ) , but I didn't know that there is any IoC that supports private set properties. So I guess Castle Windsor supports. I will have a look. | |
| Sep 30, 2017 at 14:21 | comment | added | Mathieu Guindon | @AramKocharyan ah, a service locator! The thought occurred to me I admit, but IMO that's against DI best practices; I'm pretty sure the real, cleanest solution, involves property injection - except Ninject's property injection support requires set-only properties, which is a no-no for me. So the ultimate solution is to ditch Ninject, get on with Castle Windsor, and do proper property injection =) | |
| Sep 30, 2017 at 8:10 | history | tweeted | twitter.com/StackCodeReview/status/914039791779491840 | ||
| Sep 30, 2017 at 7:49 | comment | added | Aram Kocharyan | @Mat'sMug I asked similar ( almost same question ) I have a bit different approach there, you can have a look :) codereview.stackexchange.com/questions/176620/… | |
| Sep 30, 2017 at 2:43 | history | edited | Mathieu Guindon | CC BY-SA 3.0 |
edited tags
|
| Sep 30, 2017 at 2:23 | history | edited | Mathieu Guindon | CC BY-SA 3.0 |
deleted 40 characters in body
|
| Sep 30, 2017 at 2:20 | comment | added | Mathieu Guindon | @202_accepted I'm not sure I see how a dictionary would help, feel free to post an answer! | |
| Sep 30, 2017 at 2:17 | history | edited | Mathieu Guindon | CC BY-SA 3.0 |
added 324 characters in body
|
| Sep 30, 2017 at 2:09 | comment | added | Der Kommissar |
Friend, you know what I'm gonna suggest. Build a Dictionary of the maps and iterate the piss out of that baby. :)
|
|
| Sep 30, 2017 at 1:59 | history | asked | Mathieu Guindon | CC BY-SA 3.0 |