Skip to main content

Timeline for Antlr Visitor with complex result

Current License: CC BY-SA 4.0

12 events
when toggle format what by license comment
Dec 13, 2019 at 2:26 history edited this CC BY-SA 4.0
Correct some minor grammatical typos
May 25, 2019 at 21:12 comment added dfhwze When I read "To avoid storing a state in the visitor", I'm tempted to ask: Could you use a listener instead?
Nov 18, 2017 at 1:31 vote accept this
Sep 21, 2017 at 11:51 history edited this CC BY-SA 3.0
Added 4th question RE: SRP
Sep 21, 2017 at 4:44 history tweeted twitter.com/StackCodeReview/status/910726389690707969
Sep 20, 2017 at 15:33 comment added this That's exactly correct. This will be addressed in a future iteration. For right now it's more important to have a functional Extract Method.
Sep 20, 2017 at 14:05 comment added Mathieu Guindon Excluding control flow statements makes for a simpler implementation, but eventually if a GoTo jump refers to a line label/number that's within the selection, the selection should be deemed valid: the visitor will eventually need to use a DeclarationFinder to find the declaration for the line label/number being referred to by a GoTo statement, and then verify that the line label/number isn't being jumped-to by statements that aren't within the selection.
Sep 20, 2017 at 13:57 answer added Mathieu Guindon timeline score: 2
Sep 20, 2017 at 8:40 history edited this CC BY-SA 3.0
corrected another typo
Sep 20, 2017 at 8:26 history edited Heslacher CC BY-SA 3.0
added 7 characters in body
Sep 20, 2017 at 7:39 review First posts
Sep 20, 2017 at 7:47
Sep 20, 2017 at 7:36 history asked this CC BY-SA 3.0