Timeline for Refactor Jquery .text () function
Current License: CC BY-SA 3.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 4, 2017 at 10:18 | comment | added | Icepickle |
Good remark about let, didn't realize that it changes the behavior of a variable :)
|
|
| Aug 4, 2017 at 9:47 | history | edited | Craig Ayre | CC BY-SA 3.0 |
edited body
|
| Aug 4, 2017 at 9:36 | comment | added | Craig Ayre |
@Icepickle, good spot - forgot about that quirk for a second due to using const/let
|
|
| Aug 4, 2017 at 9:31 | history | edited | Craig Ayre | CC BY-SA 3.0 |
edited body
|
| Aug 4, 2017 at 9:27 | comment | added | Icepickle |
selector in your case will always be .may since the selector is part of the for - loop. You could be using the selector from the jQuery this context here. For the rest , I think it's in general a good approach. The only thing you would be unsure of is wether or not the OP had the intention to evaluate the header only at the start of his code, or throughout the changes. I cannot say what the intentions were as I don't know what the words mean...
|
|
| Aug 4, 2017 at 8:53 | history | answered | Craig Ayre | CC BY-SA 3.0 |