Timeline for Class for scraping images with JSoup
Current License: CC BY-SA 3.0
5 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 27, 2017 at 18:42 | vote | accept | progonkpa | ||
| Jul 13, 2017 at 21:09 | comment | added | ndm13 | There's no need to. Typically methods that don't use any instance fields should be static, but it's not a hard-and-fast rule. | |
| Jul 13, 2017 at 21:05 | comment | added | progonkpa | I took your advice about fields and state in account. The private methods with one liners are intended to make the code easier to read but I might have went overboard so I cut down on it. GenericArticleScraper is common code which could be in a super class but I decided to favour composition over inheritance. Your assumptions where spot on, your tips made the class cleaner imo. I'm not too excited about making the methods from your comment static . I don't see the need or value, maybe you can clarify. Tnx either way! | |
| Jul 11, 2017 at 16:08 | comment | added | ndm13 |
Upon revisiting this, a few methods could be made static, specifically replaceIllegalFileNameCharacters, createBaseName, createName, and createExtension.
|
|
| Jul 9, 2017 at 23:36 | history | answered | ndm13 | CC BY-SA 3.0 |