Timeline for Creating clearly defined methods with generics and delegates
Current License: CC BY-SA 3.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 6, 2017 at 13:58 | comment | added | Adriano Repetti |
I understand, I think it may be better to do not hard-code this convention. If the two actions are unrelated then you should expose a (static) method Report.GetReportPathFromId(Guid reportId) instead of repeat that logic inside RunReport() and inside web app. It's a small thing but it helps to avoid changes in multiple places when logic is updated (for example if you decide to move temp reports to a different path or to split them in different directories with different cleaning rules, just to say)
|
|
| Jul 6, 2017 at 13:32 | comment | added | Brian Ge | I meant to say it always gets cleared out from our server at the end of the day, it's up to them to save reports. The paths are used in an API route that is accessed from the web application. The user selects a date range, the api route generates a GUID, calls RunReport, and responds with the report ID. The web app calls the route with the report ID. The route checks for the report .work and .json files and responds accordingly and the web app will retry until it's done or hits max retries. | |
| Jul 6, 2017 at 13:16 | comment | added | Brian Ge | Thanks for all the advice. The reports are being saved in the temp path because they aren't meant to be kept, they are generated on demand for a web application where the user can save the report manually if desired, otherwise it gets cleared out at the end of the day. | |
| Jul 6, 2017 at 12:23 | history | edited | Adriano Repetti | CC BY-SA 3.0 |
added 16 characters in body
|
| Jul 6, 2017 at 12:23 | vote | accept | Brian Ge | ||
| Jul 6, 2017 at 11:26 | history | answered | Adriano Repetti | CC BY-SA 3.0 |