Timeline for Stopwatch that uses the abstract factory design pattern
Current License: CC BY-SA 3.0
29 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 10, 2017 at 11:16 | comment | added | globalturist | @SimonForsberg No problem. Thanks for the link i'l remove the update. | |
| Jul 10, 2017 at 10:27 | comment | added | Simon Forsberg | Please do not update the code in your question to incorporate feedback from answers, doing so goes against the Question + Answer style of Code Review. This is not a forum where you should keep the most updated version in your question. Please see what you may and may not do after receiving answers. | |
| Jul 10, 2017 at 10:27 | history | rollback | Simon Forsberg |
Rollback to Revision 3
|
|
| Jul 10, 2017 at 8:12 | history | edited | globalturist | CC BY-SA 3.0 |
deleted 93 characters in body
|
| Jul 10, 2017 at 7:13 | history | edited | globalturist | CC BY-SA 3.0 |
improved formatting
|
| Jul 9, 2017 at 17:56 | history | edited | globalturist | CC BY-SA 3.0 |
corrected variable names
|
| Jul 9, 2017 at 17:36 | vote | accept | globalturist | ||
| Jul 9, 2017 at 17:35 | history | edited | globalturist | CC BY-SA 3.0 |
revamped code added
|
| Jul 4, 2017 at 0:46 | answer | added | sehe | timeline score: 8 | |
| Jul 3, 2017 at 9:13 | vote | accept | globalturist | ||
| Jul 9, 2017 at 17:36 | |||||
| Jul 3, 2017 at 5:52 | history | tweeted | twitter.com/StackCodeReview/status/881752448855101441 | ||
| Jul 2, 2017 at 23:57 | answer | added | sehe | timeline score: 8 | |
| Jul 2, 2017 at 19:51 | history | reopened |
πάντα ῥεῖ forsvarir Jerry Coffin c++ Users with the c++ badge or a synonym can single-handedly close c++ questions as duplicates and reopen them as needed. |
||
| Jul 2, 2017 at 19:26 | review | Reopen votes | |||
| Jul 2, 2017 at 19:51 | |||||
| Jul 2, 2017 at 19:18 | comment | added | globalturist | @Jerry Coffin i forgot to notify you about the previous 3 comments i left | |
| Jul 2, 2017 at 19:14 | comment | added | πάντα ῥεῖ | I already voted to reopen it. It needs another 4 votes, or @jerry (who could that do single hendedly). | |
| Jul 2, 2017 at 19:13 | comment | added | globalturist | @πάντα ῥεῖ Thanks for the advice! only question is, is it possible to unflag this question as it is not a duplicate ? | |
| Jul 2, 2017 at 19:11 | comment | added | πάντα ῥεῖ | Yes, I think so. | |
| Jul 2, 2017 at 19:10 | comment | added | globalturist | @πάντα ῥεῖ will the above edit suffice ? | |
| Jul 2, 2017 at 19:08 | history | edited | globalturist | CC BY-SA 3.0 |
deleted 9462 characters in body
|
| Jul 2, 2017 at 19:04 | comment | added | πάντα ῥεῖ | As mentioned you can write a follow up just show the different code to review, and leave the link to the original question. The other dupe voter was @Jerry BTW, not @Jamal. | |
| Jul 2, 2017 at 19:01 | comment | added | globalturist | @πάντα ῥεῖ Sorry about that i'm pretty new here and i didn't see anything written about this case specifically in the rules i will have it in mind next time, as for why i left the duplicate code in here (Console, Constants and digits libraries) I thought that if someone searches for a ready made solution he would want to use all of the code and not only the non duplicate, as to address the followup I don't see the codes as the same, yes they use the same design pattern but they Work completely differently and i wanted to know if i implemented the pattern correctly in both cases. | |
| Jul 2, 2017 at 18:52 | comment | added | πάντα ῥεῖ | So can't you handle these variants being reviewed together with your previous question, or at least state that this one is a follow-up (with a link), and leave out the duplicated code? | |
| Jul 2, 2017 at 18:38 | comment | added | globalturist | Please i ask you to compare StopWatch.h, StopWatch.cpp and source.cpp to the link you marked as a duplicate (Watch.h, watch.cpp and source.cpp) and tell me if both of those codes are exactly the same (which they are not) | |
| Jul 2, 2017 at 18:32 | comment | added | globalturist | the only thing in common is the digits.h and Console.h but StopWatch.h is nothing like watch.h it even has different functions and implementations, note that it doesn't even have a singleton class like the watch.h has | |
| Jul 2, 2017 at 18:30 | comment | added | globalturist | can you please explain how it this a duplicate ? I wrote both the watch and the stop watch and the code is completely different for both of them so why the downvote ? | |
| Jul 2, 2017 at 18:10 | history | closed |
πάντα ῥεῖ Jerry Coffin c++ Users with the c++ badge or a synonym can single-handedly close c++ questions as duplicates and reopen them as needed. |
Duplicate of Watch that uses the abstract factory design pattern | |
| Jul 2, 2017 at 17:57 | history | edited | Jamal | CC BY-SA 3.0 |
added 8 characters in body; edited tags
|
| Jul 2, 2017 at 17:55 | history | asked | globalturist | CC BY-SA 3.0 |