Timeline for Basic request script
Current License: CC BY-SA 3.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jun 13, 2017 at 20:13 | vote | accept | geostocker | ||
| Jun 13, 2017 at 15:06 | comment | added | geostocker |
Cool! Well I'm sure I don't need to do any more refactoring. All the solutions will be decoupled, so they won't share any sort of code between themselves. I might create a common interface with argparse to allow a user to get the passwords from one place. I'll have to see how I decide to solve it later. :)
|
|
| Jun 13, 2017 at 15:03 | comment | added | alecxe | @geostocker in terms of PEP8, we are more or less good to go with my version. But, code organization wise, it's difficult to tell - this is a very small piece of code. We'll need to see if it will grow, where and how, if it is gonna be usable, understandable and readable or not. At this stage, it's probably too early to tell. | |
| Jun 13, 2017 at 14:57 | comment | added | geostocker | Nono, not the logic. More so how it's written. I'm thinking about pep8 standards etc. :) Since all my code goes on github, which is publicly available for future employers I'm hoping to keep it as well-documented and written as possible! :) | |
| Jun 13, 2017 at 14:56 | comment | added | alecxe |
@geostocker no problem. Do you mean the logic of parsing the response? Well, this is an HTML response and probably a proper way to deal with that would be to HTML-parse it..eg. with BeautifulSoup - locate the div with id="content" element and get it's text..thanks.
|
|
| Jun 13, 2017 at 14:53 | comment | added | geostocker | Thanks for the feedback! I've already configured my solution to the next natas with this in mind. Will definitely change natas4 too, when I'm done! :) What about my syntax in response? Do you think that looks fine? :/ | |
| Jun 13, 2017 at 14:47 | history | answered | alecxe | CC BY-SA 3.0 |