Skip to main content
Code Review

Return to Question

edited tags
Link
200_success
200_success
  • 144.2k
  • 22
  • 188
  • 473
This is no an angular question
Link
edit approved May 1, 2017 at 3:22
Igor Soloydenko
edit approved May 1, 2017 at 3:22
Igor Soloydenko
  • 3.5k
  • 21
  • 36
Source Link
user57881
user57881

TypeScript, checking for keys and subkeys and its variants

How to reduce code size?

  getAlreadySaved(goal: GoalModel): number {

        if (goal.status && goal.status.investedAmount && !goal.status.pendingIncoming && !goal.status.pendingOutgoing) {
            return goal.status.investedAmount;

        } else if (goal.status && goal.status.investedAmount && goal.status.pendingIncoming && !goal.status.pendingOutgoing) {
            return goal.status.investedAmount + goal.status.pendingIncoming;

        } else if (goal.status && goal.status.investedAmount && !goal.status.pendingIncoming && goal.status.pendingOutgoing) {
            return goal.status.investedAmount - goal.status.pendingOutgoing;

        } else if (goal.status && goal.status.investedAmount && goal.status.pendingIncoming && goal.status.pendingOutgoing) {
            return goal.status.investedAmount + goal.status.pendingIncoming - goal.status.pendingOutgoing;

        } else {
            return 0;
        }

    }