Timeline for Get Ajax request implementation without jQuery
Current License: CC BY-SA 3.0
5 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 30, 2017 at 7:01 | comment | added | Philip | Thanks for your comment. You're right. I am new to this and learning with every post. I've updated my answer. | |
| Mar 30, 2017 at 6:57 | history | edited | Philip | CC BY-SA 3.0 |
added 1134 characters in body
|
| Mar 28, 2017 at 18:23 | comment | added | Mike Brant | Just rewriting code without explaining what you rewrote and why does not really give much value to either the original question poster or to others reading the answer. Therefore it doesn't really amount to a code review at all. Can you elaborate here? | |
| Mar 28, 2017 at 11:30 | comment | added | le_m |
Very nice! Don't mind me suggesting a few additional ideas: The default options + options merging could be a bit more localized instead of all over the place. opts.body || null might set an incorrect null POST body for e.g. opts.body = 0. Also, the callback receives an Error when an application layer error occurs (HTTP status code) but a ProgressEvent when a transport layer error occurs (xhr.onerror) which seems a bit quirky.
|
|
| Mar 28, 2017 at 11:01 | history | answered | Philip | CC BY-SA 3.0 |