Timeline for Laravel - Authentication Controller
Current License: CC BY-SA 3.0
17 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 12, 2017 at 9:48 | vote | accept | Trojan404 | ||
| Feb 10, 2017 at 6:23 | history | tweeted | twitter.com/StackCodeReview/status/829938903276728320 | ||
| Feb 9, 2017 at 22:49 | answer | added | Mike Brant | timeline score: 1 | |
| Feb 9, 2017 at 21:08 | comment | added | Trojan404 | Updated full class headers. @MikeBrant | |
| Feb 9, 2017 at 21:07 | history | edited | Trojan404 | CC BY-SA 3.0 |
Updated full class files
|
| Feb 9, 2017 at 18:35 | comment | added | Mike Brant | I agree with other comments that the full class files should be included. I reviewed your other question, and admit I had some struggles at times in knowing what inheritance and namespacing aspects were coming into play. Just saying "I am using Laravel" via a tag on your post is not enough. | |
| Feb 9, 2017 at 17:39 | comment | added | Trojan404 | @JamesFenwick I understand that for the most part, which is why all of my models are included. However, when I say I'm using laravel, that to me answers your question. I see no point to fix this question as to add your answers I would have to modify my code repository to include it without needless white space. | |
| Feb 9, 2017 at 17:36 | comment | added | James Fenwick | It is fine to use those classes. It just needs to be included in the question as part of the code. | |
| Feb 9, 2017 at 17:31 | comment | added | Trojan404 | @JamesFenwick tushe. However, why would I use the laravel framework and not use those classes? The other option is to write your own model and controller class which would have been it's own code review request. | |
| Feb 9, 2017 at 17:30 | comment | added | James Fenwick |
App\Http\Controller extends Illuminate\Routing\Controller directly, with the addition of some traits.
|
|
| Feb 9, 2017 at 17:28 | comment | added | Trojan404 | @JamesFenwick your correct on the model, however, the Controller is way off. Laravel creates its own controller class and includes it within the App\Http\Controllers directory. That's just a part of the framework. | |
| Feb 9, 2017 at 17:12 | comment | added | James Fenwick |
I assumed that you were using Illuminate\Routing\Controller and Illuminate\Database\Eloquent\Model but without knowing for sure your code cannot be reviewed.
|
|
| Feb 9, 2017 at 16:51 | comment | added | Trojan404 | @JamesFenwick I can add the class headers, however it won't do anything. This is laravel and the class extensions are literally just Controller and Model. These two classes are built straight into the framework. | |
| Feb 9, 2017 at 11:14 | comment | added | James Fenwick | Please add class headers, it is imposible to tell what you are extending without them. | |
| Feb 9, 2017 at 5:41 | history | edited | Trojan404 | CC BY-SA 3.0 |
added 96 characters in body
|
| Feb 9, 2017 at 5:31 | history | edited | 200_success | CC BY-SA 3.0 |
added 46 characters in body; edited tags
|
| Feb 9, 2017 at 4:46 | history | asked | Trojan404 | CC BY-SA 3.0 |