Timeline for Helper that swaps out some text for certain icons
Current License: CC BY-SA 3.0
14 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 30, 2016 at 20:55 | history | rollback | Simon Forsberg |
Rollback to Revision 6
|
|
| Nov 30, 2016 at 20:54 | comment | added | Simon Forsberg | Welcome to Code Review! Please do not update the code in your question to incorporate feedback from answers, doing so goes against the Question + Answer style of Code Review. This is not a forum where you should keep the most updated version in your question. Please see what you may and may not do after receiving answers. | |
| Nov 30, 2016 at 20:51 | vote | accept | DNorthrup | ||
| Nov 30, 2016 at 20:51 | comment | added | DNorthrup | @Jonah You're right. I forget about that, such a simple fix. I appreciate the nit-picking! Naming conventions is a failure of mine. | |
| Nov 30, 2016 at 20:43 | comment | added | Jonah |
In the refactored version, you need hash = hash.merge(repetitive_cost_entries) or use the mutating version (i don't recommend this) hash.merge!(repetitive_cost_entries). also, use a guard clause at the top instead of a big if... else: return if card.nil?. finally, just a naming nitpick, i'd remove the repetitive_ prefix from the vars at the top. in my example i'd only included it so that, conceptually, it would be clear what i was suggesting.
|
|
| Nov 30, 2016 at 20:19 | history | edited | DNorthrup | CC BY-SA 3.0 |
Added refactored example
|
| Nov 29, 2016 at 6:03 | answer | added | Jonah | timeline score: 3 | |
| Nov 28, 2016 at 20:24 | history | edited | DNorthrup | CC BY-SA 3.0 |
added 5 characters in body
|
| Nov 28, 2016 at 19:31 | history | edited | DNorthrup | CC BY-SA 3.0 |
deleted 4 characters in body
|
| Nov 28, 2016 at 19:21 | history | edited | DNorthrup | CC BY-SA 3.0 |
added 32 characters in body
|
| Nov 28, 2016 at 19:11 | history | edited | Jamal | CC BY-SA 3.0 |
deleted 35 characters in body; edited title
|
| Nov 28, 2016 at 19:07 | history | edited | DNorthrup | CC BY-SA 3.0 |
Removed extra section
|
| Nov 28, 2016 at 19:01 | review | First posts | |||
| Nov 28, 2016 at 19:07 | |||||
| Nov 28, 2016 at 18:58 | history | asked | DNorthrup | CC BY-SA 3.0 |