Timeline for Basic modular calculator
Current License: CC BY-SA 3.0
12 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 6, 2015 at 3:56 | history | edited | Robin Maben | CC BY-SA 3.0 |
added 48 characters in body
|
| Aug 11, 2012 at 6:53 | comment | added | Robin Maben | @st-boost: I should apologize for my lack of attention to detail too. | |
| Aug 11, 2012 at 3:39 | comment | added | delete me |
@RobinMaben I'm sorry if I offended you; my goal was to prevent readers from learning bad habits by assuming accepted answers are always correct, and to help you improve your answer. If you'd like help fixing your code, tell me what part you want help with and I'd be glad to write a more thorough explanation. (also, please start your reply with @st-boost, so it appears in my inbox and I don't have to manually check back)
|
|
| Aug 10, 2012 at 4:47 | history | edited | Robin Maben | CC BY-SA 3.0 |
added 70 characters in body
|
| Aug 10, 2012 at 4:45 | comment | added | Robin Maben | Don't be like that. Keep the OP's code in context. | |
| Aug 10, 2012 at 3:28 | comment | added | delete me |
This post introduces a staggering number of errors. Some lines before var statements are terminated with commas, which is invalid syntax. addition is a leaked global variable. parseInt, as written, will fail for input like "010". The switch statement is broken. addition is much slower due to an entirely unnecessary use of arguments. operator is a reserved word, so the entire program won't run on some engines. The entire structure is needlessly complex. And the spacing is off in a few places.
|
|
| Aug 9, 2012 at 11:16 | vote | accept | Om3ga | ||
| Aug 9, 2012 at 9:44 | comment | added | ANeves |
@RobinMaben You also forgot the break; in the switch. Please don't be sloppy when proposing improvements.
|
|
| Aug 8, 2012 at 22:24 | history | edited | Robin Maben | CC BY-SA 3.0 |
added 14 characters in body
|
| Aug 8, 2012 at 19:17 | comment | added | Andrey Agibalov |
Why val1, val2 and addition are global?
|
|
| Aug 8, 2012 at 19:01 | history | edited | Robin Maben | CC BY-SA 3.0 |
deleted 2 characters in body
|
| Aug 8, 2012 at 9:07 | history | answered | Robin Maben | CC BY-SA 3.0 |