Skip to main content
Code Review

Return to Question

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link
Community Bot
Community Bot
  • 1

This question is a follow-up question from herehere, where I implement the method from @vnp.

This question is a follow-up question from here, where I implement the method from @vnp.

This question is a follow-up question from here, where I implement the method from @vnp.

Notice removed Authoritative reference needed by Lin Ma
Bounty Ended with greybeard's answer chosen by Lin Ma
added 41 characters in body; edited title
Source Link
Jamal
Jamal
  • 34.9k
  • 13
  • 133
  • 237

clone Clone a linked list with a random pointer (part 2)

This question is a follow-up question from (Clone a linked list with a random pointerhere), where I implement the method from vnp@vnp.

I have tested my code and it works, but the 3 steps processing seems a bit long to me, and. I also tried to write a few ifif/elseelse, which seems a bit cluttercluttering (e.g. code like  newList.nextNode = newList.nextNode.nextNode if newList.nextNode else None). WonderingI'm wondering if there's any room to improve my code to make it even smallsmaller and more elegant?.

clone a linked list with a random pointer (part 2)

This question is a follow-up question from (Clone a linked list with a random pointer), where I implement the method from vnp.

I have tested my code works, but the 3 steps processing seems a bit long to me, and I also write a few if/else which seems a bit clutter (e.g. code like  newList.nextNode = newList.nextNode.nextNode if newList.nextNode else None). Wondering if any room to improve my code to make it even small and elegant?

Clone a linked list with a random pointer (part 2)

This question is a follow-up question from here, where I implement the method from @vnp.

I have tested my code and it works, but the 3 steps processing seems a bit long to me. I also tried to write a few if/else, which seems a bit cluttering (e.g. code like newList.nextNode = newList.nextNode.nextNode if newList.nextNode else None). I'm wondering if there's any room to improve my code to make it even smaller and more elegant.

Notice added Authoritative reference needed by Lin Ma
Bounty Started worth 50 reputation by Lin Ma
Source Link
Lin Ma
Lin Ma
  • 3.5k
  • 3
  • 33
  • 57

clone a linked list with a random pointer (part 2)

This question is a follow-up question from (Clone a linked list with a random pointer), where I implement the method from vnp.

I have tested my code works, but the 3 steps processing seems a bit long to me, and I also write a few if/else which seems a bit clutter (e.g. code like newList.nextNode = newList.nextNode.nextNode if newList.nextNode else None). Wondering if any room to improve my code to make it even small and elegant?

class LinkedListNode:
    def __init__(self, ID):
        self.ID = ID
        self.nextNode = None
        self.randomNode = None
    # return cloned new list
    def cloneList(self):
        # first step, add cloned node after each node
        node = self
        while node:
            newNode = LinkedListNode(node.ID)
            newNode.nextNode = node.nextNode
            node.nextNode = newNode
            node = node.nextNode.nextNode
        # 2nd step, setup random pointer
        node = self
        while node:
            node.nextNode.randomNode = node.randomNode.nextNode
            node = node.nextNode.nextNode

        # 3rd step, split existing and new list
        node = self
        newHead = node.nextNode
        newList = newHead
        while node:
            node.nextNode = node.nextNode.nextNode
            newList.nextNode = newList.nextNode.nextNode if newList.nextNode else None
            node = node.nextNode if node else None
            newList = newList.nextNode if newList else None

        return newHead

if __name__ == "__main__":
    node0 = LinkedListNode(0)
    node1 = LinkedListNode(1)
    node2 = LinkedListNode(2)
    node3 = LinkedListNode(3)
    node4 = LinkedListNode(4)
    node0.nextNode = node1
    node1.nextNode = node2
    node2.nextNode = node3
    node3.nextNode = node4
    node0.randomNode = node2
    node1.randomNode = node0
    node2.randomNode = node1
    node3.randomNode = node4
    node4.randomNode = node3

    newHead = node0.cloneList()

    while newHead:
        print (newHead.ID, newHead.nextNode.ID if newHead.nextNode else -1, newHead.randomNode.ID)
        newHead = newHead.nextNode