Timeline for Class that runs a query
Current License: CC BY-SA 3.0
10 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 15, 2014 at 2:04 | history | edited | Jamal | CC BY-SA 3.0 |
deleted 1 characters in body; edited title
|
| Aug 24, 2012 at 17:25 | vote | accept | Autolycus | ||
| Aug 2, 2012 at 5:11 | history | tweeted | twitter.com/#!/StackCodeReview/status/230893578161897474 | ||
| Aug 2, 2012 at 2:56 | answer | added | Paul | timeline score: 5 | |
| Aug 2, 2012 at 1:07 | comment | added | mseancole | Sorry, last comment. This probably shouldn't have been a class. You would be much better off working with procedural code first and working your way up to classes and OOP. | |
| Aug 2, 2012 at 0:59 | comment | added | mseancole |
Welcome to CR, we don't have "expert" advice, but I'll see what I can do for you. 32bitfloat did a pretty good job already, I just want to add a few things. First, variable names should be descriptive. $var1, $var2, $var3 doesn't tell us enough. Second, your style is inconsistent. The constructor's opening brace is on a new line while the testMethod()'s is on the same line. Your indentation is also pretty inconsistent. Finally, a single line of code should never be so long as to cause illegibility. You appear to know how to concatenate strings, just concatenate to $query a few times.
|
|
| Aug 2, 2012 at 0:47 | answer | added | 32bitfloat | timeline score: 6 | |
| S Aug 1, 2012 at 23:50 | history | suggested | Jean-François Côté | CC BY-SA 3.0 |
spelling error, order of word in sentence, code syntax
|
| Aug 1, 2012 at 22:56 | review | Suggested edits | |||
| S Aug 1, 2012 at 23:50 | |||||
| Aug 1, 2012 at 22:51 | history | asked | Autolycus | CC BY-SA 3.0 |