Timeline for Validating email confirmation and sending different emails to admins
Current License: CC BY-SA 3.0
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 22, 2016 at 13:38 | comment | added | rpmansion |
"I don't know what you're doing with emailBody, but judging from its format and the comments it looks like you're using it to pass arguments in a delimiter-separated string. That's odd, to say the least." I wish a could pass object to the method from an Identity that sending an email message so I don't have to do that.
|
|
| Aug 22, 2016 at 13:37 | comment | added | rpmansion | "I also don't see the point of compiling it inside if(account.Institution == null) and then not using its value." I have to check if the account is associated to an institution then I have to do something, I don't need to process it's data. | |
| Aug 22, 2016 at 13:35 | comment | added | rpmansion |
if (account.EmailConfirmed) return View("ConfirmEmail"); //return page that will say the token has expired, apoligies not being clear with this this will have a different view that contains message the generated token for email confirmation has already been processed. right now I don't have yet the knowledge to create some kind of process to make the token expired so once the email_confirmed in the database has been set to TRUE then it means it has been used already.
|
|
| Aug 22, 2016 at 13:31 | comment | added | rpmansion |
if (account.Institution.Licence.AllowedAccounts == 0) it will look the same but it has different email template that will be sent to admin.
|
|
| Aug 22, 2016 at 13:30 | comment | added | rpmansion |
EmailsNames is a class with constant properties. defining which type of emails will be used.
|
|
| Aug 22, 2016 at 13:29 | comment | added | t3chb0t | haha, on the contrary I would never give a collection class a plural name - so we're even? ;-P | |
| Aug 22, 2016 at 13:27 | comment | added | BCdotWEB |
@t3chb0t Even in such cases I don't see why. To me ColumnNames.ID is an odd construct, since it will return the name of one column. But there are no hard rules, it's just an opinion (except for collection classes, certain types of enum,...).
|
|
| Aug 22, 2016 at 13:19 | comment | added | t3chb0t |
I don't agree with the last statement, classes with contants-only, may have plural names. I do this all the time ie forColumnNames
|
|
| Aug 22, 2016 at 13:02 | history | answered | BCdotWEB | CC BY-SA 3.0 |