Timeline for Enumerating text (ranges) vertically and horizontally
Current License: CC BY-SA 3.0
4 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Aug 10, 2016 at 6:17 | comment | added | Tolani | To be honest , using readonly is a matter of style @t3chb0t . | |
Aug 10, 2016 at 4:15 | comment | added | t3chb0t | it's possible the second constructor can be called with null, null - theoretically yes but this would be huge bug in the core as there musn't be any nulls ever (as long as the index/length calculations are fine) ;-] I agree with all other points and I changed it to Dimitri's solution. It now works like a charm. I admit, mine was broken in so many places and extremely difficult to use in some places. | |
Aug 10, 2016 at 4:09 | comment | added | t3chb0t |
Thank you for the review ;-) I agree with you on some points but on others not, I will comment on the latter... Use readonly keyword I wanted all members to be properties because I thougt it might be better like that, just a prejudice ;-] passing length as a parameter - this is a vital feature because I sometimes need only a part of the string at an exact position. IsIndexInRange - this is indeed true when the enumerator is in the allowed range, the last MoveNext will exceed the count and make if false. CharEnumerator(line,2,11); - this is a vital feature too ;-)
|
|
Aug 9, 2016 at 23:40 | history | answered | Tolani | CC BY-SA 3.0 |