Skip to main content
9 events
when toggle format what by license comment
Aug 2, 2016 at 18:25 comment added WelshGandalf Thanks for the extra comments. I almost had 1 right (I just missed a tick box). Just to mention #9, thanks especially for this, when I wrote it I hated it but I couldn't think of another way even though I knew there was probably a relatively simple clean solution. I have some extensions I'm going to work on, this will give me a solid well-designed base to work from and on.
Aug 2, 2016 at 11:37 comment added Flambino @WelshGandalf (cont'd) 3. Well, true it's not a video player. Still, client is more accurate than data so some variation on that might work. 6. Yeah, I imagine you might want to make those values configurable - but cross that bridge when you come to it. When you do, I'd advise using getter methods for the values rather than "raw" instance vars. Rely on the abstraction/indirection of a method, rather than the concrete value. This makes your code more flexible.
Aug 2, 2016 at 10:42 comment added Flambino Ah, right. I think you may have set your editor to display tabs as 2 spaces wide - but it's still writing tab characters (\t). Ruby, however, conventionally uses two spaces - as in two individual space characters - instead of tab characters. You should be able to configure your editor to use "soft tabs", so that when you press the tab key, it actually types spaces instead of a tab character (and treats those two spaces as a single thing, so deleting works normally etc.)
Aug 2, 2016 at 9:47 comment added WelshGandalf 1. I set tabs to be 2 spaces in my editor which is I've read is OK? - though I completely understand you pointing it out here. 3. I agree mostly, but iplayer client isn't the best name either as you can't actually play iplayer programmes through it, 6. they can be different values and eventually I will initialise them when calling the class rather than setting them to fixed values. I suppose therefore I agree with the spirit of everything you say if not the specifics :) I think 4,5,8,9 and 10 are the ones that will help me improve the most (I've never come across a hash as a parameter before)
Aug 1, 2016 at 22:06 comment added Flambino @WelshGandalf Have to ask: Which parts do you disagree with?
Aug 1, 2016 at 22:05 history edited Flambino CC BY-SA 3.0
added 344 characters in body
Aug 1, 2016 at 21:59 comment added WelshGandalf Thanks - definitely more I agree with here than disagree with. Much to ponder on for the future.
Aug 1, 2016 at 21:58 vote accept WelshGandalf
Jul 31, 2016 at 20:10 history answered Flambino CC BY-SA 3.0