Timeline for class.FaviconFinder.php - add more validation
Current License: CC BY-SA 3.0
5 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 8, 2016 at 20:50 | comment | added | tim | @arc.slate.0 See also How to get the best value out of Code Review - Asking Questions (in addition to the points I mentioned, it also mentions tags). Please also note What you may and may not do after receiving answers, I rolled back your edit. | |
| May 8, 2016 at 20:45 | comment | added | tim | @arc.slate.0 I don't always upvote questions I answer (I do on the other hand upvote pretty much all answer to my questions). If your asking what could be improved about the question, a couple of things come to mind: the title (describe what the code does, not what you want out of a review), the missing description (just a sentence or maybe two on what your code does), don't ask about why something is broken (it seems off-topic to me), make a bit more clear what exactly you want out of a review (what validation do you mean, exactly? how/why do you want to check the integrity?, etc). | |
| May 8, 2016 at 20:38 | comment | added | arc.slate .0 | please let me know why you did not up-vote. | |
| May 8, 2016 at 20:36 | comment | added | arc.slate .0 | I agree is is too big, but keeping for now while troulbeshooting - check rev 3 - I updated some of the names. | |
| May 8, 2016 at 19:57 | history | answered | tim | CC BY-SA 3.0 |