Skip to main content
Code Review

Return to Question

Tweeted twitter.com/StackCodeReview/status/654884349582680064
edited tags
Link
h.j.k.
h.j.k.
  • 19.2k
  • 3
  • 36
  • 93
deleted 104 characters in body; edited title
Source Link
Jamal
Jamal
  • 34.9k
  • 13
  • 133
  • 237

How can I make Making a better Engineer?

I have Engineeran Engineer which looks notdoesn't look very good. Could you point me, howHow can I make him better organized? Share with me some best What about good practices!?

Here is interfaceInterface:

here is implementationImplementation:

  1. Is it OK to put constants to interface and use them in implementation the implementation?
  2. Should I make constants static finalstatic final if they are defined defined in an interface? Which constants should I prefer, intint or String String?
  3. Can I make some additional actions in setter'ssetters?
  4. When should I write a JavaDoc?

Please, keep in mind that I will use this review to refer.

How can I make better Engineer?

I have Engineer which looks not very good. Could you point me, how can I make him better organized? Share with me some best practices!

Here is interface:

here is implementation:

  1. Is it OK to put constants to interface and use them in implementation?
  2. Should I make constants static final if they are defined in interface? Which constants should I prefer, int or String?
  3. Can I make some additional actions in setter's?
  4. When should I write JavaDoc?

Please, keep in mind that I will use this review to refer.

Making a better Engineer

I have an Engineer which doesn't look very good. How can I make him better organized? What about good practices?

Interface:

Implementation:

  1. Is it OK to put constants to interface and use them in the implementation?
  2. Should I make constants static final if they are defined in an interface? Which constants should I prefer, int or String?
  3. Can I make some additional actions in setters?
  4. When should I write a JavaDoc?
added 390 characters in body
Source Link
Iaroslav Karandashev
Iaroslav Karandashev
  • 523
  • 3
  • 9

Some explicit questions:

  1. Is it OK to put constants to interface and use them in implementation?
  2. Should I make constants static final if they are defined in interface? Which constants should I prefer, int or String?
  3. Can I make some additional actions in setter's?
  4. When should I write JavaDoc?

Please, keep in mind that I will use this review to refer.

Some explicit questions:

  1. Is it OK to put constants to interface and use them in implementation?
  2. Should I make constants static final if they are defined in interface? Which constants should I prefer, int or String?
  3. Can I make some additional actions in setter's?
  4. When should I write JavaDoc?

Please, keep in mind that I will use this review to refer.

Source Link
Iaroslav Karandashev
Iaroslav Karandashev
  • 523
  • 3
  • 9