Timeline for Fibonacci heap implementation
Current License: CC BY-SA 3.0
13 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 2, 2014 at 23:29 | history | edited | RubberDuck |
edited tags
|
|
| Jul 2, 2014 at 22:34 | history | edited | Jamal | CC BY-SA 3.0 |
added 27 characters in body; edited title
|
| Dec 22, 2013 at 22:19 | history | edited | 200_success |
edited tags
|
|
| Mar 24, 2012 at 11:40 | history | tweeted | twitter.com/#!/StackCodeReview/status/183518572339937280 | ||
| Mar 20, 2012 at 17:00 | vote | accept | ChaosPandion | ||
| Mar 19, 2012 at 10:30 | answer | added | ANeves | timeline score: 1 | |
| Mar 19, 2012 at 9:37 | comment | added | ANeves | @ChaosPandion you are absolutely right in that answers should not be posted as comments. But since I do not feel confident about reviewing the actual code, I left it for someone else to address. I'll write down an answer, on style. | |
| Mar 18, 2012 at 3:11 | comment | added | ChaosPandion |
@Leonid - Write up an answer. The suggestion about the if is pretty good. I must have originally had some more code in there.
|
|
| Mar 18, 2012 at 2:43 | comment | added | Leonid |
Disclaimer: I gave it a superficial read without having VS2010 by my side. I second variable names, I would run StyleCop on this and listen to suggestions of it. I would rewrite one else { if as elseif. I personally would make the whole body of public void Push(TKey key, TValue value) a one-liner.
|
|
| Mar 16, 2012 at 19:13 | comment | added | ChaosPandion | @ANeves - By the way I would consider this a rough draft. Typically if I cannot quickly come up with a useful name I'll use a poor name and try again on a second pass. | |
| Mar 16, 2012 at 19:07 | comment | added | ChaosPandion | @ANeves - Why don't you make your opinion more prominent by writing an answer? Keep in mind that this code has no dependencies so you can easily try it out. | |
| Mar 16, 2012 at 19:04 | comment | added | ANeves |
a, x, d, y, t: I think I would really enjoy reading your code if not for these random variable names. i, n are proper one-letter variable names because they are obvious, but the others are just confusing.
|
|
| Mar 16, 2012 at 17:00 | history | asked | ChaosPandion | CC BY-SA 3.0 |