Readability
The script is hard to read because code blocks are not indented,
and there are not blank lines to separate cohesive units.
Consider this alternative writing style of the same script:
file="/var/www/check.txt"
if [ -e $file ]
then
sudo apt-get update
sudo git -C /var/www/html pull https://username:[email protected]/username/repository.git
else
sudo apt-get update
sudo apt-get install apache2 libapache2-mod-php5 php5-mcrypt php5-mysql git -y
sudo cat <<EOF > /etc/apache2/mods-enabled/dir.conf
<IfModule mod_dir.c>
DirectoryIndex index.php index.cgi index.pl index.html index.xhtml index.htm
</IfModule>
# vim: syntax=apache ts=4 sw=4 sts=4 sr noet
EOF
sudo rm -rf /var/www/html
sudo git clone https://username:[email protected]/username/repository.git /var/www/html/ /var/www/html/
sudo cat <<EOF > /var/www/check.txt
aanwezig!
EOF
fi
I know, this is still not so great, due to the here-documents interrupting the indented blocks.
We'll improve that in another step.
sudo and here-documents
The scope of sudo is strictly the specified command.
For example in sudo date > /tmp/out,
the date command will be executed as root,
but the redirection is a different matter,
it will be executed by the shell, as the current user, not root.
Try this yourself, the owner of /tmp/out will be the current user, not root.
This means that the sudo cat <<EOF ... commands don't work as you may think they do. If you want to create a file as root from a here-document,
you can write like this:
cat <<EOF | sudo tee /etc/apache2/mods-enabled/dir.conf
<IfModule mod_dir.c>
DirectoryIndex index.php index.cgi index.pl index.html index.xhtml index.htm
</IfModule>
# vim: syntax=apache ts=4 sw=4 sts=4 sr noet
EOF
The fact that you haven't noticed the problem suggests that maybe the script is already running as root,
so you don't need any of the sudo.
Here-documents and formatting
Since here-documents break the indentation,
I recommend extracting them to helper functions, for example:
print_mod_dir() {
cat <<EOF
<IfModule mod_dir.c>
DirectoryIndex index.php index.cgi index.pl index.html index.xhtml index.htm
</IfModule>
# vim: syntax=apache ts=4 sw=4 sts=4 sr noet
EOF
}
print_mod_dir | sudo tee /etc/apache2/mods-enabled/dir.conf
Although the here-document disrupts the indentation of the function,
that's ok, because the entire function body is about the here-document,
so it's less intrusive as elsewhere.
The rest of the code can be nicely readable, for example:
file="/var/www/check.txt"
sudo apt-get update
if [ -e $file ]
then
sudo git -C $docroot pull $repo
else
sudo apt-get update
sudo apt-get install apache2 libapache2-mod-php5 php5-mcrypt php5-mysql git -y
print_mod_dir | sudo tee /etc/apache2/mods-enabled/dir.conf
sudo rm -rf $docroot
sudo git clone $repo $docroot $docroot
sudo touch $file
fi
I replaced some repeated values with variables as @RubberDuck suggested in his review.
I also replaced the second here-document creating a file with a single line,
because as far as this script is concerned,
it's enough if the file exists,
and touch is the perfect tool for that.
Naming
What is file?
What is /var/www/check.txt?
Neither the variable name nor the file name tell anything useful to the reader.
It would be better to use names that make your intention obvious to readers.
