Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

Simply put, is this function a correct and safe way to add and/or subtract time to a tm struct (from time.h)?

void AddTime(int seconds, tm *date)
{
    date->tm_sec += seconds;
    mktime(date);
}

Seconds could be any value, supposedly larger than 60 (or smaller than -60); I'm using mktime to readjust the other values in tm, but I don't know if that's right.

I'm also not taking into account going below 1970 or above 3001 for the year, which I think are the default bounds for mktime to operate. I can check for that elsewhere.

share|improve this question

2 Answers 2

up vote 3 down vote accepted

I would add a sanity check on the pointer as well:

void AddTime(int seconds, tm* date) {
    if (date == NULL) return;
    date->tm_sec += seconds;
    mktime(date);
}

But other than that it looks correct.

EDIT. Reading some documentation on mktime this appears to be what it was meant for.

share|improve this answer

You should put more validations.

For example if you add more than 60 seconds you need to increment minutes too. If minutes value is 59 you must increment hours too.

..

share|improve this answer
1  
I thought mktime distributed the overflows accordingly. Does it not? –  MPelletier Nov 29 '12 at 13:59
1  
mktime does perform normalization on its values –  seand Nov 29 '12 at 16:47

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.