Tell me more ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

The title says it all really.

What materials have you read (or in another way learned from) that make you a better reviewer?

1 item per answer please - let the good ones get the votes ;-)

share|improve this question
14  
Hopefully we can all add codereview.stackexchange.com to this list soon! – Wade Tandy Jan 19 '11 at 22:42
Would make this a wiki if I could – LRE Jan 19 '11 at 22:46
only mods can change a question to CW - flag it and someone will change it eventually. – BenV Jan 19 '11 at 23:04
1  
Questions about the discipline and practice of code reviews should be posted to programmers.stackexchange.com. This site is for sharing code from projects you're working on to get peer feedback and review. – Robert Cartaino Jan 21 '11 at 15:51

closed as off topic by BitOff, Inaimathi, Robert Cartaino Jan 21 '11 at 15:51

Questions on Code Review Stack Exchange are expected to relate to code review request within the scope defined in the FAQ. Consider editing the question or leaving comments for improvement if you believe the question can be reworded to fit within the scope. Read more about closed questions here.

15 Answers

Refactoring: Improving the Design of Existing Code

alt text

share|improve this answer
2  
this one should be mandatory reading – LRE Jan 19 '11 at 23:06
How do I make my links nice like this to Amazon? – Mark Loeser Jan 20 '11 at 1:37
@Mark Add ** for boldness! – Greg Buehler Jan 20 '11 at 5:06

I'm amazed this one hasn't been mentioned yet. Anyone doing any software development should read this:

Design Patterns: Elements of Reusable Object Oriented Software

Design Patterns: Elements of Reusable Object Oriented Software

share|improve this answer
+1, was just going to add that one – cbrulak Jan 20 '11 at 2:19
add Head First Design Patterns as the introduction and you've got a winner – LRE Jan 21 '11 at 3:43

I would add to the list

Then again, I'd imagine SO already has a pretty comprehensive book listing on this subject

share|improve this answer
-1: Too localized to a single language. – Sergio Tapia Jan 21 '11 at 1:00

Definitely without a doubt a website called Refactor my Code. It's not something you can physically read, but in relation to code reviewing, it can sometimes be a big help.

share|improve this answer

Facts and Fallacies of software engineering: http://www.amazon.ca/Facts-Fallacies-Software-Engineering-Robert/dp/0321117425

share|improve this answer
Why two answers? I suppose this is better for a community wiki question, but I'm not sure. – Donovan Jan 19 '11 at 23:03
@Alberteddu - I did ask for one item per answer to allow people to vote on individual items – LRE Jan 19 '11 at 23:09
Oh, did not see the one item per answer thing in your question. I'm sorry. – Donovan Jan 19 '11 at 23:21
+1 I removed my answer - didn't see this one :) – Aim Kai Jan 20 '11 at 14:07

I've found this useful in getting some tidbits from others in the field: Programming Pearls

share|improve this answer

C++ specific, but still an excellent resource: Effective C++

share|improve this answer
and its' sequels – LRE Jan 20 '11 at 1:35

Code Quality: The Open Source Perspective

Code Quality: The Open Source Perspective

I found Code Quality, the Open Source Perspective and impressive book. Analysing common openSource Projects, it shows bad habbits etc.

share|improve this answer

A very good site to show what bad code looks like (among other things):

http://thedailywtf.com/

(also very good for a laugh - and yes I'm serious, this is a good resource for learning about code quality)

share|improve this answer

Take a look at this book as well...

I.M. Wright's "Hard Code" Eric Brechner http://oreilly.com/catalog/9780735624351

share|improve this answer

Not the answer you're looking for? Browse other questions tagged or ask your own question.