Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

I need to select all checked checkboxes, except checkboxes having a class ".checkall".

HTML:

<input type="checkbox" value="1961" class="checkbox">
<input type="checkbox" name="checkall" class="checkbox checkall">

Script:

$("input.checkbox:checkbox:checked:not(.checkall)").each(function () {
    var checkbox = $(this), machineId = checkbox.val()
}
share|improve this question
add comment

2 Answers 2

up vote 5 down vote accepted

I just posted on your other post about this, use:

$("input[type=checkbox]:checked:not(.checkall)")

This is the 'regular' way to check for input tags of a particular type, it's much clearer than your way. I'm not sure what the significance of the .checkbox class is but it seems like it's not necessary to my.

I also recommend you cache your check boxes in a variable and search that multiple times. That way you're only searching the check boxes each time instead of the whole DOM.

// in document ready
var checkboxes = $('input[type=checkbox]');

// When you need to find the checked check boxes
var checked = checkboxes.find(':checked:not(.checkall)');
share|improve this answer
    
sweet!. clear and concise. thanks –  Shane Km Mar 6 '13 at 9:45
add comment

Addionally to @Tyriar's answer:

You possibly could optimize the selection even more depending on where the checkboxes are in the HTML by making the selector more specific and possibly modifying the HTML to help with that.

For example, if all checkboxes are the same element, add it's ID (or class) as a parent in the selector:

$("#mytable input[type=checkbox]:checked:not(.checkall)")

Also :not isn't very efficient. If the "check all" checkboxes were, for example, in the thead of a table while the checkboxes you need are in the tbody then use:

$("#mytable tbody input[type=checkbox]:checked")
share|improve this answer
    
cool. thanks!!! –  Shane Km Mar 6 '13 at 13:34
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.