My code blinks text for an interval of time then clears the text.

I plan to use this code in a quiz web app. When the user gets an answer right, "CORRECT!" will blink on the screen for 10 seconds. When the user gets an answer wrong, "INCORRECT!" will blink on the screen for 10 seconds.

I'm looking for feedback on how I could simplify and improve it?

<div id="blinkText"></div>

<script>
// Takes text to blink and id of element to blink text in

// Flag to see what state text is in (true or false)
var flag = true;

// Number of times to blink text
var i = 1;
var divID = document.getElementById(id);

if (flag) {
divID.innerHTML = text;
flag = false;
} else {
divID.innerHTML = "";
flag = true;
}

i++;
} else {
// Delete if it's still showing
divID.innerHTML = "";

}
}
}

</script>

-
I would suggest using a library, for example: docs.jquery.com/UI/Effects/Pulsate – abuzittin gillifirca Jan 31 '13 at 15:08

It doesn't look very complex to me but the variable names could use some attention, as they're not very descriptive. I'd suggest:

• textHidden instead of flag
• timesBlinked instead of i
• targetElement instead of divID (it's not an id anymore, but the element referred to by the id)

I would also toggle the element visibility instead of removing and adding the text for several reasons, one of them being that removing text can also change the element's height and/or width, which can cause problems with the layout.

if( textHidden ) {
targetElement.style.visibility = 'visible';
} else {
targetElement.style.visibility = 'hidden';
}

textHidden = !textHidden;  // flip the flag

-