Should i use ?-expression in this case?

Question

Is a ?-expression ok in this case:

cobBereich.DropDownStyle = (cobBereich.DropDownStyle == ComboBoxStyle.DropDownList ? ComboBoxStyle.DropDown : ComboBoxStyle.DropDownList);

Is it overkill? Would a IF-Else be easier to understand for other coders (or to maintain)?

Answer 1

It's a question of personal preference. I would personally prefer the following formatting:

cobBereich.DropDownStyle = (cobBereich.DropDownStyle == ComboBoxStyle.DropDownList) 
    ? ComboBoxStyle.DropDown 
    : ComboBoxStyle.DropDownList;

Answer 2

From you logic I am assuming you have two possible values and you want to switch the current value to the other one?

If so, I must admit that it is not clear immediately this is what you are trying to do. For this reason, I would personally prefer to use an if else statement which would be easier to read/follow:

//switch the value
if(cobBereich.DropDownStyle == ComboBoxStyle.DropDownList)
    cobBereich.DropDownStyle = ComboBoxStyle.DropDown;
else
    cobBereich.DropDownStyle = ComboBoxStyle.DropDownList;

Of course, the code you have already is perfectly valid. So I would say go with what you find easier to read.

Answer 3

Expanding on @almaz's answer, I have started formatting my code as the following:

cobBereich.DropDownStyle = 
    (cobBereich.DropDownStyle == ComboBoxStyle.DropDownList)
        ? ComboBoxStyle.DropDown 
        : ComboBoxStyle.DropDownList;

I find that putting the conditional expression on a new line helps keep it from being swallowed up in a single long line, and keeps the position consistent, independent of variable name lengths.

Answer 4

No, this is nowhere near overkill. This is exactly the case that the conditional operator was designed for. Looks A-OK.

EDIT: now that I see almaz's answer, I agree wholeheartedly that formatting is key to making the conditional operator maintainable.