Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

I'm still teaching myself C out of KN King's C Programming: Modern Approach. Actually pretty excited I go this problem solved in under 2 hours. I asked this over on Stack Overflow and it was recommended I post it here.

The exercise is to print a magic square. My solution works but it feels incredibly convoluted. I'm wondering if it actually is? If anyone can help me reorganise the logic in this I'd appreciate it, or am I on the right track? Bear in mind this is Chapter 8, and we've only covered basics like loops, conditional statements, single and 2d arrays etc. I'm open to all constructive feedback.

The question:

Write a program that prints an n x n magic square (a square arrangement of the numbers 1, 2, ..., n2 in which the sums of the rows, columns and diagonals are all the same). The user will specify the value of n.

Store the magic square in a 2D array. Start by placing the numbers 1 in the middle of row 0. Place each of the remaining numbers 2, 3, ...n2 by moving up one row and over one column.

Any attempt to go outside the bounds of the array should "wrap around" to the opposite side of the array. For example, instead of storing the next number in row -1, we would store it in row n - 1 (the last row). Instead of storing the next number in column n, we would store it in column 0.

If a particular array element is already occupied, put the number directly below the previously stored number. If your compiler supports variable length arrays, declare the array to have n rows and n columns. If not, declare the array to have 99 rows and 99 columns.

My answer:

// KN King Chapter 8
// Programming Projects
// Exercise 17 - Magic Square

#include <stdio.h>

int main() {

    // Introductory message
    printf("This program creates a magic sqaure of a specified size.\n");
    printf("The size must be an odd number between 1 and 99.\n");

    // Get the users magic number and allocate to int n
    int n;
    printf("Enter size of magic square: ");
    scanf("%d", &n);

    // Create the array (not using VLA)
    int magic[99][99];
    int start = (n / 2); // The middle column
    int max = n * n; // The final number
    magic[0][start] = 1; // Place the number one in the middle of row 0

    // Loop to start placing numbers in the magic square
    int row;
    int col;
    int next_row;
    int next_col;
    int i;
    for (i = 2, row = 0, col = start; i < max + 1; i++) {
        if ((row - 1) < 0) { // If going up one will leave the top
            next_row = n - 1; // Go to the bottom row
        }
        else { next_row = row - 1; } // Otherwise go up one
        printf("In row: %d\n", row);

        if ((col + 1) > (n - 1)) { // If column will leave the side
            next_col = 0; // Wrap to first column
            printf("Column will leave side\n");                                   
        }                                                                         
        else { next_col = col + 1; } // Otherwise go over one                     
        printf("In col: %d\n", col);                                              

        if (magic[next_row][next_col] > 0) { // If that position is taken         
            if (row > (n - 1)) { // If going to row below leaves bottom           
                next_row = 0; // Go back to the top                               
            }                                                                     
            else {                                                                
                next_row = row + 1; // Go to the row below                        
                next_col = col; // But stay in same column                        
            }                                                                     
        }                                                                         
        row = next_row;                                                           
        col = next_col;                                                           
        printf("About to put %d in row %d, col %d\n", i, row, col);               
        magic[row][col] = i; // Put the current value in that position            
    }                                                                             

    // Now let's print the array                                                  
    int j;                                                                        
    for (i = 0; i < n; i++) {                                                     
        for (j = 0; j < n; j++) {                                                 
            printf("%4d", magic[i][j]);                                           
        }                                                                         
        printf("\n");                                                             
    }                                                                             
    return 0;                                                                     
}
share|improve this question
    
Starting the for-loop at i=2 seems a bit weird to me. I would recommend starting at i=1 and putting current value at be beginning of the loop –  sfk Jan 27 '13 at 16:03
    
I agree with you @sfk it does seem a little weird, but how do I place the 1 in the middle of the top row to start? I guess I could start the row and col one down and to the left so it goes up to the correct spot to place the starting 1. –  aussie_aj Jan 28 '13 at 2:53
add comment

2 Answers

up vote 1 down vote accepted

I'm just using the Ith row and Jth column formula here on wiki.

Formula

The loop will become:

for( i = 0; i < n; i++ ) {
  for( j = 0; j < n; j++ ) {
    magic[i][j] = n * ( (i + j - 1 + floor(n / 2)) % n ) + ( (i + 2 * j - 2) % n ) + 1;
  }
}

Ofcourse, you'd need to include # include <math.h> at the beginning so that floor() may work.

Here's the working ideone link, with sample inputs. ignore the clutter by input = 99 :)

share|improve this answer
    
Thanks! I didn't even know it could be done this way. That certainly cleans it up a lot. I guess for the point of the way the author wanted the exercise done mine is the way it has to be. –  aussie_aj Jan 28 '13 at 2:52
add comment

I'm a beginner, studying on King. I've been doing this exercise last night. I found a simpler code, here's the ideone link: http://ideone.com/wD2EpN

The solution on the answer is really lean, but it doesn't work, rows and columns start from 0. Then it should be:

for(i = 0; i < n; i++) {
       for(j = 0; j < n; j++) {
           magic[(n -1 + i)%n][(n - 1 + j)%n] = n * ((i + j - 1 + (n - 1) / 2) % n) + ((i + 2 *     j - 2) % n) + 1;
       }
 }

By the way, I guess this is what King was asking, since we had to use vectors and 'for' loops. The exercise was asking to move columns and row "by hand".

share|improve this answer
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.