Tell me more ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote -1 down vote favorite

I am going to adopt TDD in our team and one of the ideas I have is to review tests first. So one would write interfaces, mocks, and tests first, submit them for a code review and once interfaces and tests (think specification) are approved an actual implementation can be written (theoretically, can be done by another developer). I wonder how viable this idea is?

share|improve this question
2  
I think this question is more appropriate for Programmers. – S.L. Barth Dec 14 '12 at 6:09

closed as off topic by Corbin, Jeff Vanzella, Paul, Brian Reichle, seand Dec 14 '12 at 16:57

Questions on Code Review Stack Exchange are expected to relate to code review request within the scope defined in the FAQ. Consider editing the question or leaving comments for improvement if you believe the question can be reworded to fit within the scope. Read more about closed questions here.

1 Answer

up vote 0 down vote

It is too bureaucratic and slow approach. It is better to:

  • discuss implementation (developer with architect/team lead/senior developer, or on a sprint meeting with whole team)
  • let developer implement and unit test that (I wouldn't force developers to do tests first)
  • do a code review to ensure that it corresponds to discussed plan and both code and unit tests are of a good quality
share|improve this answer

Not the answer you're looking for? Browse other questions tagged or ask your own question.