C++ program Segmentation fault for Selection Sort in ascending order [closed]

Question

The program compiles but the numbers do not sort and it ends with "segmentation fault". Help? I am using a c++ compiler

void Selection_sort(int [], int); 
void Swap (int*, int &, int &);
void Display_list(int [], int);

int main (){
const int   count=10; // number of input values
int     i=0;

int List[count];

cout << "Enter " << count << " values: ";

for (i=0; i<count; i++)
{
cin >> List[i];
}

Display_list(List, count); // before sorting

Selection_sort(List, count);



Display_list(List, count); // after sorting

return 0;
}

void Selection_sort(int L[], int cnt){
int largest;
int i;
int n=i-1;

for(i=1; i<10; i++)
{
if (L[i]>largest)
largest= L[i];
Swap(L,largest,n);
}
}

void Swap (int l[],int &A, int &B){
int temp;
temp=l[B];
l[B]=l[A];
l[A]=temp;


}

void Display_list(int L[], int cnt){
cout<<"The numbers in this array are : \n"<<endl;
for (int i=0; i<cnt; i++)
cout<<L[i]<<endl;   
cout<<"\n"<<endl; 
}

Answer 1

---

void Selection_sort(int L[], int cnt){
int largest;    
int i;

largest and i should be initialized because you use i directly:

int n=i-1;

or maybe you meant cnt:

   #include <climits>

   int largest = std::numeric_limits<int>::min();
   int n = cnt - 1;

---

Also add some asserts inside your functions to check the indices just to be on the safe side.

I would also recommend using a std::vector instead of a native array, it offers much more flexibility and is safer to use