Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

I would really love to hear your critiques on:

  • Code quality
  • Code clarity
  • More efficient alternative code

Code:

function array_mask(array $source, array $filter){
    foreach ($source as $key => $value){
        if (!isset($filter[$key])){
            if (array_search($key, $filter) !== false){
                continue;
            }
            unset($source[$key]);
        } else {
            if (is_array($source[$key])){
                $source[$key] = array_mask($source[$key], $filter[$key]);
            }
        }
    }
    return $source;
} 


$source = array(
    'page' => array(
        'q' => 'alkflsdj',
        'x' => 1,
        9   => 'm'
    ),
    'news' => 7
);
$filter = array(
    'page' => array(
        9
    ),
    'news'
); 

$result = array_mask($source, $filter);
var_dump($result);

Result:

array
  'page' => 
    array
      9 => string 'm' (length=1)
  'news' => int 7
share|improve this question

2 Answers 2

up vote 2 down vote accepted

You can use built-in functions instead. Like this for example:

function array_mask(array $source, array $filter)
{
    $source = array_intersect_key($source, $filter);

    foreach ($source as $key => $value)
        if (is_array($value))
            $source[$key] = array_mask($source[$key], $filter[$key]);

    return $source;
}

$source = array(
    'page' => array(
        'q' => 'alkflsdj',
        'x' => 1,
        9   => 'm'
    ),
    'news' => 7
);
$filter = array(
    'page' => array(
        9 => ''
    ),
    'news' => ''
);

var_dump (array_mask($source, $filter));
share|improve this answer
    
I had this idea, but for some reason she didn't like. Now like normal. –  Fedor Nov 14 '12 at 17:20

Looks good to me, but you can make a small optimization:

change this

        if (array_search($key, $filter) !== false){
            continue;
        }
        unset($source[$key]);

to

        if (array_search($key, $filter) === false){
            unset($source[$key]);
        }
share|improve this answer
1  
Just a suggestion, you might want to explain why you are suggesting the change. Doing so will greatly increase the value of this answer. –  Jeff Vanzella Nov 14 '12 at 17:01

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.