Is this a right and effcient way of checking AND in a for loop

Question

Just saw this at work in a code review and was wondering if this style of coding - for loop, doing && like that, seems fine to you or is there a better way of doing the same?

for (int j = 1; j <= ETtop; j++)
{ 
    // Check everything.
    int k = ET[j].PriIdx;
    for (int z = 1; z <= ET[k].ArgTop; z++ )
    {
        // Check to make sure every Argument in the equation is valid.
        // If it's a calc this is only true if it's been evaluated.
        ready = ready && ET[k].Arg[z].Valid;
    }
}

Answer 1

Currently, once you get ready to be false, all other checks after that will fail (as false && condition2 will always be false).

Why not just break out of the inner for loop when ET[k].Arg[z].Valid is false? If ready is needed, you may keep the assignment line, but break when it's false.

Answer 2

If possible, I would rewrite your code to use collections instead of indexers and top properties. That way, you could use foreach instead of for, or, even better, LINQ:

ready = ET.All(e => e.Arg.All(arg => arg.Valid))

or:

ready = (from e in ER
         from arg in e.Arg
         select arg.Valid)
       .All();

This most likely won't make your code faster (although it does use short-circuit evaluation), but it will make it more readable, IMHO.