Can you guys help me to improve this Arduino code for animatronic hand? [closed]

Question

I am making a animatronic hand that is powered by two Arduinos connected via XBee radio's. I am very new to coding and this is my first attempt. I was wondering if you guys could help me a little as as of now I don't know if it works as I don't have the Ardunios and I would like to try to get the code perfect before the build as that is going to be a difficult job! Could you guys help clean up this code a bit as well? Thanks in advance!

Here is the hands code:

http://pastebin.com/hvLLB0z6

Here is the glove code:

http://pastebin.com/bdKA6idN

Thanks very much!

Answer 1

Knowing nothing about Arduino or hands, I can safely say the above code cannot be correct.

I'm just throwing some things that jump to the eye:

1. You wait for 5 bytes on the serial buffer, and than you read MAX_FINGERS times in the loop. So if MAX_FINGERS != 5, you'll be out of order next time.
2. It's hard to believe the byte that you write() to the servo, by itself, has any meaning. There has to be some conversion there.

Just in a glance. Attach full code next time and good luck with the project!