Simplifying dictionary of constant values

Question

I have the following code:

    public string GetRefStat(string pk) {
        return RefStat[pk.Substring(2, 2)];
    }
    private readonly Dictionary<String, int> RefStat =
    new Dictionary<string, int> 
    {
        {"00", REF.MenuType,       } // Menu
        {"01", REF.ReferenceStatus,} // Article
        {"02", REF.ReferenceStatus,} // Favorites List
        {"03", REF.ReferenceStatus,} // Content Block
        {"06", REF.ReferenceStatus } // Topic
    };

GetRefStat and the dictionary are always used together.

Is there a way I could simplify and combine these? I was wondering if I could put the information in a static class and then have a get method that returned the information I needed.

Answer 1

Your code is short, readable and efficient, so I don't think it needs much improvement. And I don't think adding a static class would give you anything (although changing the field and the method to static could make sense).

Another way to write your code would be to use switch, but I'm not sure whether it's more readable (although it could be slightly more efficient):

public string GetRefStat(string pk)
{
    switch (pk.Substring(2, 2))
    {
    case "00":
        return REF.MenuType;
    case "01":
    case "02":
    case "03":
    case "06":
        return REF.ReferenceStatus;
    default:
        throw new InvalidOperationException();
    }
}